prow: add preset-ci-operator-image-pull preset#75830
prow: add preset-ci-operator-image-pull preset#75830petr-muller wants to merge 1 commit intoopenshift:mainfrom
Conversation
Add a Prow preset that provides the registry pull credentials volume and volumeMount to Prowjobs labeled with preset-ci-operator-image-pull: "true". This is a proof of concept for using compositional Prow presets to deduplicate boilerplate from the 126K+ generated ci-operator Prowjobs. Each preset covers one logical domain and can be independently composed. The corresponding prowgen change adds this label to all generated jobs and stops inlining the pull-secret volume/mount in the PodSpec. Requires the corresponding prowgen change in openshift/ci-tools: https://github.com/openshift/ci-tools/pull/XXXXX Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: petr-muller The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
Regenerate all Prowjob definitions using the modified prowgen that uses the preset-ci-operator-image-pull Prow preset instead of inlining the pull-secret volume and volumeMount in every job PodSpec. Per-job changes: - Added label: preset-ci-operator-image-pull: "true" - Removed: pull-secret volumeMount (3 lines) - Removed: pull-secret volume definition (3 lines) - Net: -5 lines per job 25,666 files changed, -633K lines net reduction. Depends on: - Preset definition: openshift#75830 - Prowgen change: openshift/ci-tools#4994 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
/test prow-config |
|
@petr-muller: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
Proof of concept for using Prow presets to deduplicate boilerplate from the 126K+ generated ci-operator Prowjob definitions.
This PR adds a preset to the Prow config that provides the
pull-secretvolume and volumeMount to any Prowjob labeled withpreset-ci-operator-image-pull: "true".Changes
core-services/prow/02_config/_config.yaml: Addpreset-ci-operator-image-pullpreset definitionDesign
This is the first of several compositional, domain-specific presets — each covers one logical domain with its own label, and they compose independently. See the companion ci-tools PR for the full design.
Rollout
make updaterun — regenerates all jobs, removing ~888K lines of boilerplate and adding the label.Companion PR
Requires the prowgen change in openshift/ci-tools: openshift/ci-tools#4994
Test plan
make checkconfigpasses with the preset definedmake updateregenerates jobs correctly🤖 Generated with Claude Code