Skip to content

jobs: regenerate with preset-ci-operator-image-pull#75831

Draft
petr-muller wants to merge 2 commits intoopenshift:mainfrom
petr-muller:preset-ci-operator-image-pull-jobs
Draft

jobs: regenerate with preset-ci-operator-image-pull#75831
petr-muller wants to merge 2 commits intoopenshift:mainfrom
petr-muller:preset-ci-operator-image-pull-jobs

Conversation

@petr-muller
Copy link
Member

Summary

Regenerate all Prowjob definitions using the modified prowgen that uses the preset-ci-operator-image-pull Prow preset instead of inlining the pull-secret volume and volumeMount in every job PodSpec.

Per-job change

 labels:
   ci.openshift.io/generator: prowgen
+  preset-ci-operator-image-pull: "true"
 ...
 volumeMounts:
-  - mountPath: /etc/pull-secret
-    name: pull-secret
-    readOnly: true
 ...
 volumes:
-  - name: pull-secret
-    secret:
-      secretName: registry-pull-credentials

Stats

  • 25,666 files changed
  • +126,657 / -759,942 lines (net -633,285 lines)
  • -5 lines per job (1 label added, 6 lines of volume/mount removed)

Dependency chain

  1. prow: add preset-ci-operator-image-pull preset #75830 — preset definition (merge first)
  2. prowgen: use preset for registry pull credentials volume ci-tools#4994 — prowgen change
  3. This PR — regenerated jobs (merge last)

Test plan

  • make checkconfig passes
  • Preset correctly resolves at runtime (volume/mount injected by Prow)
  • Sample job runs successfully with preset-provided credentials

🤖 Generated with Claude Code

petr-muller and others added 2 commits March 6, 2026 19:06
Add a Prow preset that provides the registry pull credentials
volume and volumeMount to Prowjobs labeled with
preset-ci-operator-image-pull: "true".

This is a proof of concept for using compositional Prow presets to
deduplicate boilerplate from the 126K+ generated ci-operator Prowjobs.
Each preset covers one logical domain and can be independently composed.

The corresponding prowgen change adds this label to all generated jobs
and stops inlining the pull-secret volume/mount in the PodSpec.

Requires the corresponding prowgen change in openshift/ci-tools:
https://github.com/openshift/ci-tools/pull/XXXXX

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Regenerate all Prowjob definitions using the modified prowgen that
uses the preset-ci-operator-image-pull Prow preset instead of inlining
the pull-secret volume and volumeMount in every job PodSpec.

Per-job changes:
- Added label: preset-ci-operator-image-pull: "true"
- Removed: pull-secret volumeMount (3 lines)
- Removed: pull-secret volume definition (3 lines)
- Net: -5 lines per job

25,666 files changed, -633K lines net reduction.

Depends on:
- Preset definition: openshift#75830
- Prowgen change: openshift/ci-tools#4994

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 6, 2026
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 6, 2026
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@petr-muller: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: petr-muller
Once this PR has been reviewed and has the lgtm label, please assign bartoszmajsak, jupierce, oharan2 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants