fix: regenerate package-lock and fix eslint errors#191
Merged
arbrandes merged 1 commit intoopenedx:mainfrom Mar 19, 2026
Merged
fix: regenerate package-lock and fix eslint errors#191arbrandes merged 1 commit intoopenedx:mainfrom
arbrandes merged 1 commit intoopenedx:mainfrom
Conversation
Closed
Closed
arbrandes
force-pushed
the
fix-lint-errors
branch
from
99ba8ae to
c9d7440
Compare
arbrandes
changed the title
arbrandes
force-pushed
the
fix-lint-errors
branch
from
c9d7440 to
a99232d
Compare
Regenerate package-lock and fix resulting linting errors. This includes disabling the prefer-optional-chain rule in the base config. Also fix IDE type checking under tools/ by adding babel.config.js to the tsconfig include list. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
arbrandes
force-pushed
the
fix-lint-errors
branch
from
a99232d to
c146efb
Compare
| }], | ||
| '@typescript-eslint/no-empty-function': 'off', | ||
| '@typescript-eslint/prefer-nullish-coalescing': 'off', | ||
| '@typescript-eslint/prefer-optional-chain': 'off', |
Contributor
There was a problem hiding this comment.
Why are we disabling this on globally?
Contributor
Author
There was a problem hiding this comment.
This is just a style preference, but it's here primarily for backward compatibility. If we enable this we'll have to fix it across the board: and there are quite a few transgressions in the codebase, right now. (Unlike the nullish coalescing one, which sometimes we explicitly don't want.)
holaontiveros
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Regenerate package-lock.json and fix assorted eslint errors across runtime, shell, and tools.
Disable the
prefer-optional-chainrule globally in the shared eslint config. Widen theno-require-importsoverride to match nested config files via**/glob prefixes, and remove a redundant copy of that override from the rooteslint.config.js.Fix IDE type checking under tools/ by adding
babel.config.jsto the tsconfig include list.LLM usage notice
Built with assistance from Claude models (mostly Opus 4.6).