Skip to content

fix: regenerate package-lock and fix eslint errors #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arbrandes merged 1 commit into from
Mar 19, 2026
Merged

fix: regenerate package-lock and fix eslint errors #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3,327 changes: 1,987 additions & 1,340 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 0 additions & 1 deletion runtime/utils.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import { waitFor } from '@testing-library/react';
import {
camelCaseObject,
convertKeyNames,
Expand Down
2 changes: 0 additions & 2 deletions shell/header/AuthenticatedMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ interface AuthenticatedMenuProps {
export default function AuthenticatedMenu({ className }: AuthenticatedMenuProps) {
const authenticatedUser = useAuthenticatedUser();

// We're using '||' on purpose to detect an empty string, so ignore eslint's warning:
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
const displayUserName = authenticatedUser?.name || authenticatedUser?.username;

const title = (
Expand Down
34 changes: 4 additions & 30 deletions test-site/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions tools/eslint/base.eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ module.exports = tseslint.config(
}],
'@typescript-eslint/no-empty-function': 'off',
'@typescript-eslint/prefer-nullish-coalescing': 'off',
'@typescript-eslint/prefer-optional-chain': 'off',
Copy link
Contributor

@holaontiveros holaontiveros Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we disabling this on globally?

Copy link
Contributor Author

@arbrandes arbrandes Mar 19, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a style preference, but it's here primarily for backward compatibility. If we enable this we'll have to fix it across the board: and there are quite a few transgressions in the codebase, right now. (Unlike the nullish coalescing one, which sometimes we explicitly don't want.)

'@stylistic/semi': ['error', 'always', { omitLastInOneLineBlock: true, omitLastInOneLineClassBody: true }],
'@stylistic/quotes': ['error', 'single', {
avoidEscape: true,
Expand All @@ -113,9 +114,9 @@ module.exports = tseslint.config(
},
{
files: [
'babel.config.js',
'jest.config.js',
'eslint.config.js'
'**/babel.config.js',
'**/jest.config.js',
'**/eslint.config.js'
],
rules: {
'@typescript-eslint/no-require-imports': 'off'
Expand Down
3 changes: 2 additions & 1 deletion tools/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"defaultConfigPaths.ts",
"eslint/**/*",
"eslint.config.js",
"jest.config.js"
"jest.config.js",
"babel.config.js"
]
}
4 changes: 1 addition & 3 deletions tools/webpack/plugins/html-webpack-new-relic-plugin/HtmlWebpackNewRelicPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@ enum OptionTypes {
TRUST_KEY = 'trustKey',
}

type HtmlWebpackNewRelicPluginOptions = {
[key in OptionTypes]: string | undefined;
};
type HtmlWebpackNewRelicPluginOptions = Record<OptionTypes, string | undefined>;

export default class HtmlWebpackNewRelicPlugin {
options: HtmlWebpackNewRelicPluginOptions;
Expand Down
Loading