fix: resolve eslint errors

Regenerate package-lock and fix resulting linting errors.  This includes
disabling the prefer-optional-chain rule in the base config.

Also fix IDE type checking under tools/ by adding babel.config.js to the
tsconfig include list.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: arbrandes

package-lock.json

@@ -1,4 +1,3 @@
-import { waitFor } from '@testing-library/react';
 import {
   camelCaseObject,
   convertKeyNames,

runtime/utils.test.js

@@ -13,8 +13,6 @@ interface AuthenticatedMenuProps {
 export default function AuthenticatedMenu({ className }: AuthenticatedMenuProps) {
   const authenticatedUser = useAuthenticatedUser();
 
-  // We're using '||' on purpose to detect an empty string, so ignore eslint's warning:
-  // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
   const displayUserName = authenticatedUser?.name || authenticatedUser?.username;
 
   const title = (

shell/header/AuthenticatedMenu.tsx

@@ -88,6 +88,7 @@ module.exports = tseslint.config(
       }],
       '@typescript-eslint/no-empty-function': 'off',
       '@typescript-eslint/prefer-nullish-coalescing': 'off',
+      '@typescript-eslint/prefer-optional-chain': 'off',
       '@stylistic/semi': ['error', 'always', { omitLastInOneLineBlock: true, omitLastInOneLineClassBody: true }],
       '@stylistic/quotes': ['error', 'single', {
         avoidEscape: true,
@@ -113,9 +114,9 @@ module.exports = tseslint.config(
   },
   {
     files: [
-      'babel.config.js',
-      'jest.config.js',
-      'eslint.config.js'
+      '**/babel.config.js',
+      '**/jest.config.js',
+      '**/eslint.config.js'
     ],
     rules: {
       '@typescript-eslint/no-require-imports': 'off'

test-site/package-lock.json

@@ -18,6 +18,7 @@
     "defaultConfigPaths.ts",
     "eslint/**/*",
     "eslint.config.js",
-    "jest.config.js"
+    "jest.config.js",
+    "babel.config.js"
   ]
 }

tools/eslint/base.eslint.config.js

@@ -14,9 +14,7 @@ enum OptionTypes {
   TRUST_KEY = 'trustKey',
 }
 
-type HtmlWebpackNewRelicPluginOptions = {
-  [key in OptionTypes]: string | undefined;
-};
+type HtmlWebpackNewRelicPluginOptions = Record<OptionTypes, string | undefined>;
 
 export default class HtmlWebpackNewRelicPlugin {
   options: HtmlWebpackNewRelicPluginOptions;