Open
Conversation
… being labelled as 3.2.6
Contributor
Author
|
@nf-core-bot fix linting please |
mashehu
reviewed
Mar 27, 2026
Contributor
Author
|
Sorry, I think I did another mistake |
mashehu
reviewed
Mar 27, 2026
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
mashehu
reviewed
Mar 27, 2026
| file(process.out.h5[0][1]).name, | ||
| process.out.versions, | ||
| file(process.out.log[0][1]).name, | ||
| process.out.versions_minia, |
Contributor
There was a problem hiding this comment.
Suggested change
| process.out.versions_minia, | |
| process.out.findAll { key, val -> key.startsWith('versions') }, |
mashehu
reviewed
Mar 27, 2026
| - minia: | ||
| type: string | ||
| description: The name of the tool | ||
| - minia -v | grep Minia | sed 's/Minia version //g': |
Contributor
There was a problem hiding this comment.
Suggested change
| - minia -v | grep Minia | sed 's/Minia version //g': | |
| - minia -v | sed -n 's/Minia version //p': |
mashehu
reviewed
Mar 27, 2026
| - minia: | ||
| type: string | ||
| description: The name of the tool | ||
| - minia -v | grep Minia | sed 's/Minia version //g': |
Contributor
There was a problem hiding this comment.
Suggested change
| - minia -v | grep Minia | sed 's/Minia version //g': | |
| - minia -v | sed -n 's/Minia version //p': |
mashehu
reviewed
Mar 27, 2026
| @@ -4,17 +4,18 @@ process MINIA { | |||
|
|
|||
| conda "${moduleDir}/environment.yml" | |||
Contributor
There was a problem hiding this comment.
can you update the version number in this file as well please
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains an update for Minia.
Changes include:
PR checklist
Closes #11056
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda