DUPLICATE Update deprecated usage of get_package_share#3705
Draft
nbbrooks wants to merge 5 commits intomoveit:mainfrom
Draft
DUPLICATE Update deprecated usage of get_package_share#3705nbbrooks wants to merge 5 commits intomoveit:mainfrom
nbbrooks wants to merge 5 commits intomoveit:mainfrom
Conversation
…and ament_index_cpp::get_package_share_directory(*, *) to ament_index_cpp::get_package_share_path(package_name) addressing ament/ament_index#112 Revert QT support changes which will be addressed in a separate PR Temporarily add '-Wno-error=deprecated-declarations' to suppress other upstream deprecatios from short circuiting CI
6 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3705 +/- ##
==========================================
- Coverage 46.24% 0.00% -46.23%
==========================================
Files 726 49 -677
Lines 59483 5678 -53805
Branches 7624 1034 -6590
==========================================
- Hits 27504 0 -27504
+ Misses 31813 5678 -26135
+ Partials 166 0 -166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Timple
reviewed
Mar 15, 2026
|
|
||
| #include <rclcpp/version.h> | ||
|
|
||
| // For Rolling, L-turtle, and newer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I started addressing ament/ament_index#112 here but it is not released yet
Description
Testing some additional changes to #3703 following the migration pattern in ros2/rviz#1671
I temporarily turned off the deprecations as errors warnings in the CI job, so that CI doesnt short circuit due to other upstream deprecations. We should configure a separate CI job for this so when we are trying to address deprecations we aren't forced to do it all in one PR.
I am looking at #3493 for QT6 support.
Checklist