Update deprecated usage of get_package_share#3703
Update deprecated usage of get_package_share#3703stephanie-eng wants to merge 5 commits intomoveit:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3703 +/- ##
==========================================
- Coverage 46.24% 0.00% -46.23%
==========================================
Files 726 539 -187
Lines 59483 47596 -11887
Branches 7624 6085 -1539
==========================================
- Hits 27504 0 -27504
- Misses 31813 47596 +15783
+ Partials 166 0 -166 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stephanie-eng
force-pushed
the
seng/update-get-package-share
branch
2 times, most recently
from
be406a2 to
f9eb433
Compare
stephanie-eng
force-pushed
the
seng/update-get-package-share
branch
from
f9eb433 to
f0b9544
Compare
|
No, this is to address ament/ament_index#104 in Rolling distro - ament/ament_index#112 is not released to debians yet. |
| { | ||
| try | ||
| { | ||
| return std::filesystem::path(ament_index_cpp::get_package_share_directory(package_name)); |
There was a problem hiding this comment.
Why not
return ament_index_cpp::get_package_share_path(package_name);
There was a problem hiding this comment.
thanks for the review - I moved to this pattern in #3705
There was a problem hiding this comment.
I just realized ament/ament_index#112 is not released to debians yet and the CI breakage Stephanie is referring to is ament/ament_index#104
There was a problem hiding this comment.
I was hoping not too many folks would run into this.
It was a strange syntax and deviation from python. Therefor I rushed the new syntax.
Still people affected I see, bummer.
Net syntax does save you some lines in the future though :)
| try | ||
| { | ||
| package_path = ament_index_cpp::get_package_share_directory(package_name); | ||
| ament_index_cpp::get_package_share_directory(package_name, path); |
There was a problem hiding this comment.
path = ament_index_cpp::get_package_share_path(package_name);
|
@stephanie-eng could you turn on "Allow edits from maintainers" so I can push some changes? For now I duplicated this PR in #3705 |
|
|
This reverts commit f0b9544. Qt6 migration will be handled in a separate branch. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Temporarily disable deprecation warning-as-error for QT and ament_target_dependencies deprecation warnings
3 participants
Description
CI appears to be borked. Maybe this will help.
Checklist