Update --search option description with aka.ms link and field filter details#17544
Open
JamesNK wants to merge 2 commits into
Open
Update --search option description with aka.ms link and field filter details#17544JamesNK wants to merge 2 commits into
JamesNK wants to merge 2 commits into
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 17544Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 17544" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Aspire CLI --search option description text to mention full-text search, field filters, and an aka.ms link for more details, and propagates those string updates into localization XLF files.
Changes:
- Updated telemetry
--searchhelp text to mention full-text + field-filter support and addedhttps://aka.ms/aspire/cli-search. - Updated logs
--searchhelp text to add the aka.ms link. - Updated corresponding entries in multiple
*.xlflocalization files.
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Aspire.Cli/Resources/TelemetryCommandStrings.resx | Updates telemetry --search option description text and adds aka.ms link. |
| src/Aspire.Cli/Resources/LogsCommandStrings.resx | Updates logs --search option description text to include aka.ms link. |
| src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.zh-Hant.xlf | Updates localized XLF source/target for telemetry SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.zh-Hans.xlf | Updates localized XLF source/target for telemetry SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.tr.xlf | Updates localized XLF source/target for telemetry SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.ru.xlf | Updates localized XLF source/target for telemetry SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.pt-BR.xlf | Updates localized XLF source/target for telemetry SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.pl.xlf | Updates localized XLF source/target for telemetry SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.ko.xlf | Updates localized XLF source/target for telemetry SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.ja.xlf | Updates localized XLF source/target for telemetry SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.it.xlf | Updates localized XLF source/target for telemetry SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.fr.xlf | Updates localized XLF source/target for telemetry SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.es.xlf | Updates localized XLF source/target for telemetry SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.de.xlf | Updates localized XLF source/target for telemetry SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/TelemetryCommandStrings.cs.xlf | Updates localized XLF source/target for telemetry SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/LogsCommandStrings.zh-Hant.xlf | Updates localized XLF source/target for logs SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/LogsCommandStrings.zh-Hans.xlf | Updates localized XLF source/target for logs SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/LogsCommandStrings.tr.xlf | Updates localized XLF source/target for logs SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/LogsCommandStrings.ru.xlf | Updates localized XLF source/target for logs SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/LogsCommandStrings.pt-BR.xlf | Updates localized XLF source/target for logs SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/LogsCommandStrings.pl.xlf | Updates localized XLF source/target for logs SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/LogsCommandStrings.ko.xlf | Updates localized XLF source/target for logs SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/LogsCommandStrings.ja.xlf | Updates localized XLF source/target for logs SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/LogsCommandStrings.it.xlf | Updates localized XLF source/target for logs SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/LogsCommandStrings.fr.xlf | Updates localized XLF source/target for logs SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/LogsCommandStrings.es.xlf | Updates localized XLF source/target for logs SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/LogsCommandStrings.de.xlf | Updates localized XLF source/target for logs SearchOptionDescription. |
| src/Aspire.Cli/Resources/xlf/LogsCommandStrings.cs.xlf | Updates localized XLF source/target for logs SearchOptionDescription. |
Comment on lines
+51
to
+52
| <source>Search and filter log content fields such as messages, categories, and attribute values. Supports full-text search and field filters. See https://aka.ms/aspire/cli-search for more details</source> | ||
| <target state="new">Search and filter log content fields such as messages, categories, and attribute values. Supports full-text search and field filters. See https://aka.ms/aspire/cli-search for more details</target> |
Comment on lines
+51
to
+52
| <source>Search and filter log content fields such as messages, categories, and attribute values. Supports full-text search and field filters. See https://aka.ms/aspire/cli-search for more details</source> | ||
| <target state="new">Search and filter log content fields such as messages, categories, and attribute values. Supports full-text search and field filters. See https://aka.ms/aspire/cli-search for more details</target> |
Comment on lines
50
to
53
| <trans-unit id="SearchOptionDescription"> | ||
| <source>Full-text search to filter log content</source> | ||
| <target state="new">Full-text search to filter log content</target> | ||
| <source>Search and filter log content fields such as messages, categories, and attribute values. Supports full-text search and field filters. See https://aka.ms/aspire/cli-search for more details</source> | ||
| <target state="new">Search and filter log content fields such as messages, categories, and attribute values. Supports full-text search and field filters. See https://aka.ms/aspire/cli-search for more details</target> | ||
| <note /> |
Comment on lines
+51
to
+52
| <source>Search and filter log content fields such as messages, categories, and attribute values. Supports full-text search and field filters. See https://aka.ms/aspire/cli-search for more details</source> | ||
| <target state="new">Search and filter log content fields such as messages, categories, and attribute values. Supports full-text search and field filters. See https://aka.ms/aspire/cli-search for more details</target> |
Comment on lines
+51
to
+52
| <source>Search and filter log content fields such as messages, categories, and attribute values. Supports full-text search and field filters. See https://aka.ms/aspire/cli-search for more details</source> | ||
| <target state="new">Search and filter log content fields such as messages, categories, and attribute values. Supports full-text search and field filters. See https://aka.ms/aspire/cli-search for more details</target> |
| <trans-unit id="SearchOptionDescription"> | ||
| <source>Full-text search to filter log content</source> | ||
| <target state="new">Full-text search to filter log content</target> | ||
| <source>Search and filter log content fields such as messages, categories, and attribute values. Supports full-text search and field filters. See https://aka.ms/aspire/cli-search for more details</source> |
Comment on lines
+51
to
+52
| <source>Search and filter log content fields such as messages, categories, and attribute values. Supports full-text search and field filters. See https://aka.ms/aspire/cli-search for more details</source> | ||
| <target state="new">Search and filter log content fields such as messages, categories, and attribute values. Supports full-text search and field filters. See https://aka.ms/aspire/cli-search for more details</target> |
Comment on lines
+51
to
+52
| <source>Search and filter log content fields such as messages, categories, and attribute values. Supports full-text search and field filters. See https://aka.ms/aspire/cli-search for more details</source> | ||
| <target state="new">Search and filter log content fields such as messages, categories, and attribute values. Supports full-text search and field filters. See https://aka.ms/aspire/cli-search for more details</target> |
Comment on lines
+51
to
+52
| <source>Search and filter log content fields such as messages, categories, and attribute values. Supports full-text search and field filters. See https://aka.ms/aspire/cli-search for more details</source> | ||
| <target state="new">Search and filter log content fields such as messages, categories, and attribute values. Supports full-text search and field filters. See https://aka.ms/aspire/cli-search for more details</target> |
| </data> | ||
| <data name="SearchOptionDescription" xml:space="preserve"> | ||
| <value>Full-text search to filter log content</value> | ||
| <value>Full-text search to filter log content. See https://aka.ms/aspire/cli-search for more details</value> |
Contributor
|
Re-running the failed jobs in the CI workflow for this pull request because 1 job was identified as retry-safe transient failures in the CI run attempt.
|
Contributor
|
❌ CLI E2E Tests failed — 106 passed, 1 failed, 2 unknown (commit Failed Tests
View all recordings
📹 Recordings uploaded automatically from CI run #26520377772 |
sebastienros
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates the
--searchoption description in the CLI to clarify that it supports full-text search and field filters, and adds a link tohttps://aka.ms/aspire/cli-searchfor more details.The aka.ms link will be created separately to point to the relevant documentation.
Checklist