pyoxidizer: allow specifying an existing project crate#468
Open
dae wants to merge 1 commit intoindygreg:mainfrom
Open
pyoxidizer: allow specifying an existing project crate#468dae wants to merge 1 commit intoindygreg:mainfrom
dae wants to merge 1 commit intoindygreg:mainfrom
Conversation
This was referenced Oct 24, 2021
8f998b7 to
5c5ac33
Compare
5e0524b to
789c62e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While building directly with cargo is possible (#467), a lot of the convenience that pyoxidizer provides is lost - you need to construct rather long command lines, and manually bundle files up separately (#466). What if instead of an all-or-nothing approach, pyoxidizer provided limited support for building from an existing Rust crate?
With this PR, the user can build a project created with init-rust-project with a single short command line:
It also happens to be somewhat faster, as crates like jemalloc don't get recompiled each time.
It would come with caveats:
What do you think?