pyoxidizer: avoid pyo3 recompiles when Python config has not changed#471
Draft
dae wants to merge 1 commit intoindygreg:mainfrom
Draft
pyoxidizer: avoid pyo3 recompiles when Python config has not changed#471dae wants to merge 1 commit intoindygreg:mainfrom
dae wants to merge 1 commit intoindygreg:mainfrom
Conversation
Whenever the pyo3 config file has its modification time bumped, the pyo3 crates and python-oxidized-importer get recompiled, which adds to the build time. This change brings my incremental build time down from ~24 seconds to ~10 seconds
Contributor
Author
|
Presented mainly for discussion - I will probably end up going with #466 for now instead, and this doesn't help there, as the artifacts don't seem to get regenerated by |
8f998b7 to
5c5ac33
Compare
5e0524b to
789c62e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever the pyo3 config file has its modification time bumped, the
pyo3 crates and python-oxidized-importer get recompiled, which adds
to the build time. This change brings an incremental 'pyoxidizer build'
time down from ~24 seconds to ~10 seconds.
This only makes sense in conjunction with something like #468, as
otherwise all Rust crates get recompiled each time anyway.