Make PyOxidizer build local rust project when it can find toml file#700
Open
JulianZhang wants to merge 2 commits intoindygreg:mainfrom
Open
Make PyOxidizer build local rust project when it can find toml file#700JulianZhang wants to merge 2 commits intoindygreg:mainfrom
JulianZhang wants to merge 2 commits intoindygreg:mainfrom
Conversation
Author
|
@indygreg Hi, I thank PyOxidizer is ready to build python env with user's rust project. And I also find there is another PR with same requirement 468. But the 468 was blocked because failed in checks. If you thank the solution by 468 (use env) is better, I can write a new PR use that way, and fix all checking fails. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am planning to mix Rust and Python in a new project. When I tried to build the demo project with
cargo build, I found that theadd_python_resourcestep was missing, causing some dependency files to be missing when running Python scripts. Usingpyoxidizer buildcan create the correct Python runtime environment, but it always compiles the demo Rust project.I found that the easiest solution is to modify some of the PyOxidizer code so that when there is a local project, it compiles the local project instead of creating a new demo. The current condition I have chosen is to find a
tomlfile in the current working directory (CWD).Can this change be considered for merging into the main branch?