ci: Remove Docker container for Verdaccio package publishing#20329
Merged
ci: Remove Docker container for Verdaccio package publishing#20329
Conversation
The Dockerfile.publish-packages container only provided a pinned Node.js version for running `npm publish` of pre-built tarballs. The host already has the correct Node.js version via Volta, so the Docker build+run overhead is unnecessary. Run the publish script directly on the host instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Extract the tarball publishing logic into an importable function in lib/publishPackages.ts and call it directly from registrySetup instead of spawning a subprocess. Remove the old publish-packages.ts script. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Lms24
approved these changes
Apr 15, 2026
| if: steps.restore-tarball-cache.outputs.cache-hit != 'true' | ||
| run: yarn build:tarball | ||
|
|
||
| - name: Get node version |
Member
There was a problem hiding this comment.
hmm I thought we had e2e test apps running under different node versions than the repo-wide one. Is this still possible? Might have been a thing of the past though, so given our current test apps pass, no objections to the change!
Member
Author
There was a problem hiding this comment.
IMHO this should still be fine because this just publishes to verdaccio which should work with any node version we use in our matrix,I think 🤔
mydea
added a commit
that referenced
this pull request
Apr 15, 2026
PR #20329 removed Docker-based package publishing, so E2E jobs can now run in the Playwright container without Docker-in-Docker issues. Re-add the container block to E2E jobs and use workspace-relative temp paths (runner.temp doesn't work inside containers). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mydea
added a commit
that referenced
this pull request
Apr 15, 2026
PR #20329 removed Docker-based package publishing, so E2E jobs can now run in the Playwright container without Docker-in-Docker issues. Re-add the container block to E2E jobs and use workspace-relative temp paths (runner.temp doesn't work inside containers). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
46 tasks
mydea
added a commit
that referenced
this pull request
Apr 16, 2026
PR #20329 removed Docker-based package publishing, so E2E jobs can now run in the Playwright container without Docker-in-Docker issues. Re-add the container block to E2E jobs and use workspace-relative temp paths (runner.temp doesn't work inside containers). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes some custom stuff we still had around for our E2E tests that, as far as I can tell, weren't even needed anymore. We used to spin up a minimal docker image just to publish packages to NPM, which AFAIk should not really be necessary.
Summary
Dockerfile.publish-packagesand the Docker build+run steps for publishing packages to the local Verdaccio registry during E2E testslib/publishPackages.tsas an importable function and calls it directly fromregistrySetup()— no subprocess neededpublish-packages.tsstandalone scriptE2E_TEST_PUBLISH_SCRIPT_NODE_VERSIONenv var andGet node versionsteps frombuild.ymlandcanary.ymlPUBLISH_PACKAGES_DOCKER_IMAGE_NAMEconstantThe Docker container only existed to pin a Node.js version for
npm publishof pre-built tarballs. Since the host already has the correct Node.js version via Volta, the container adds overhead (image build + volume mounts +--network host) without meaningful benefit.Test plan
🤖 Generated with Claude Code