-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
ci: Remove Docker container for Verdaccio package publishing #20329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| /* eslint-disable no-console */ | ||
| import * as childProcess from 'child_process'; | ||
| import { readFileSync } from 'fs'; | ||
| import { globSync } from 'glob'; | ||
| import * as path from 'path'; | ||
|
|
||
| const repositoryRoot = path.resolve(__dirname, '../../..'); | ||
|
|
||
| /** | ||
| * Publishes all built Sentry package tarballs to the local Verdaccio test registry. | ||
| */ | ||
| export function publishPackages(): void { | ||
| const version = (JSON.parse(readFileSync(path.join(__dirname, '../package.json'), 'utf8')) as { version: string }) | ||
| .version; | ||
|
|
||
| // Get absolute paths of all the packages we want to publish to the fake registry | ||
| // Only include the current versions, to avoid getting old tarballs published as well | ||
| const packageTarballPaths = globSync(`packages/*/sentry-*-${version}.tgz`, { | ||
| cwd: repositoryRoot, | ||
| absolute: true, | ||
| }); | ||
|
|
||
| if (packageTarballPaths.length === 0) { | ||
| throw new Error(`No packages to publish for version ${version}, did you run "yarn build:tarballs"?`); | ||
| } | ||
|
|
||
| const npmrc = path.join(__dirname, '../test-registry.npmrc'); | ||
|
|
||
| for (const tarballPath of packageTarballPaths) { | ||
| console.log(`Publishing tarball ${tarballPath} ...`); | ||
| const result = childProcess.spawnSync('npm', ['--userconfig', npmrc, 'publish', tarballPath], { | ||
| cwd: repositoryRoot, | ||
| encoding: 'utf8', | ||
| stdio: 'inherit', | ||
| }); | ||
|
|
||
| if (result.status !== 0) { | ||
| throw new Error(`Error publishing tarball ${tarballPath}`); | ||
| } | ||
| } | ||
| } |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm I thought we had e2e test apps running under different node versions than the repo-wide one. Is this still possible? Might have been a thing of the past though, so given our current test apps pass, no objections to the change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO this should still be fine because this just publishes to verdaccio which should work with any node version we use in our matrix,I think 🤔