Skip to content

Commit 5e8c190

Browse files
mydeaclaude
andcommitted
fix(ci): Restore container for E2E jobs after merging publish fix
PR #20329 removed Docker-based package publishing, so E2E jobs can now run in the Playwright container without Docker-in-Docker issues. Re-add the container block to E2E jobs and use workspace-relative temp paths (runner.temp doesn't work inside containers). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent bef9f19 commit 5e8c190

File tree

2 files changed

+29
-15
lines changed

2 files changed

+29
-15
lines changed

.github/workflows/build.yml

Lines changed: 26 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -922,8 +922,15 @@ jobs:
922922
# See: https://github.com/actions/runner/issues/2205
923923
if:
924924
always() && needs.job_e2e_prepare.result == 'success' && needs.job_e2e_prepare.outputs.matrix != '{"include":[]}'
925-
needs: [job_get_metadata, job_build, job_e2e_prepare]
925+
&& needs.job_playwright_image.result == 'success'
926+
needs: [job_get_metadata, job_build, job_e2e_prepare, job_playwright_image]
926927
runs-on: ubuntu-24.04
928+
container:
929+
image: ${{ needs.job_playwright_image.outputs.image }}
930+
credentials:
931+
username: ${{ github.actor }}
932+
password: ${{ secrets.GITHUB_TOKEN }}
933+
options: --ipc=host --user root
927934
timeout-minutes: 15
928935
env:
929936
# We just use a dummy DSN here, only send to the tunnel anyhow
@@ -989,18 +996,18 @@ jobs:
989996
working-directory: dev-packages/e2e-tests
990997

991998
- name: Copy to temp
992-
run: yarn ci:copy-to-temp ./test-applications/${{ matrix.test-application }} ${{ runner.temp }}/test-application
999+
run: yarn ci:copy-to-temp ./test-applications/${{ matrix.test-application }} ../tmp-test-application
9931000
working-directory: dev-packages/e2e-tests
9941001

9951002
- name: Build E2E app
996-
working-directory: ${{ runner.temp }}/test-application
1003+
working-directory: dev-packages/tmp-test-application
9971004
timeout-minutes: 7
9981005
run: ${{ matrix.build-command || 'pnpm test:build' }}
9991006
env:
10001007
SENTRY_E2E_WORKSPACE_ROOT: ${{ github.workspace }}
10011008

10021009
- name: Run E2E test
1003-
working-directory: ${{ runner.temp }}/test-application
1010+
working-directory: dev-packages/tmp-test-application
10041011
timeout-minutes: 10
10051012
run: ${{ matrix.assert-command || 'pnpm test:assert' }}
10061013
env:
@@ -1011,7 +1018,7 @@ jobs:
10111018
if: failure()
10121019
with:
10131020
name: playwright-traces-job_e2e_playwright_tests-${{ matrix.test-application}}
1014-
path: ${{ runner.temp }}/test-application/test-results
1021+
path: dev-packages/tmp-test-application/test-results
10151022
overwrite: true
10161023
retention-days: 7
10171024

@@ -1025,7 +1032,7 @@ jobs:
10251032
if: failure()
10261033
with:
10271034
name: E2E Test Dump (${{ matrix.label || matrix.test-application }})
1028-
path: ${{ runner.temp }}/test-application/event-dumps
1035+
path: dev-packages/tmp-test-application/event-dumps
10291036
overwrite: true
10301037
retention-days: 7
10311038
if-no-files-found: ignore
@@ -1039,9 +1046,16 @@ jobs:
10391046
if:
10401047
always() && needs.job_get_metadata.outputs.is_release != 'true' && needs.job_e2e_prepare.result == 'success' &&
10411048
needs.job_e2e_prepare.outputs.matrix-optional != '{"include":[]}' && (github.event_name != 'pull_request' ||
1042-
github.event.pull_request.head.repo.full_name == github.repository) && github.actor != 'dependabot[bot]'
1043-
needs: [job_get_metadata, job_build, job_e2e_prepare]
1049+
github.event.pull_request.head.repo.full_name == github.repository) && github.actor != 'dependabot[bot]' &&
1050+
needs.job_playwright_image.result == 'success'
1051+
needs: [job_get_metadata, job_build, job_e2e_prepare, job_playwright_image]
10441052
runs-on: ubuntu-24.04
1053+
container:
1054+
image: ${{ needs.job_playwright_image.outputs.image }}
1055+
credentials:
1056+
username: ${{ github.actor }}
1057+
password: ${{ secrets.GITHUB_TOKEN }}
1058+
options: --ipc=host --user root
10451059
timeout-minutes: 15
10461060
env:
10471061
E2E_TEST_AUTH_TOKEN: ${{ secrets.E2E_TEST_AUTH_TOKEN }}
@@ -1094,16 +1108,16 @@ jobs:
10941108
working-directory: dev-packages/e2e-tests
10951109

10961110
- name: Copy to temp
1097-
run: yarn ci:copy-to-temp ./test-applications/${{ matrix.test-application }} ${{ runner.temp }}/test-application
1111+
run: yarn ci:copy-to-temp ./test-applications/${{ matrix.test-application }} ../tmp-test-application
10981112
working-directory: dev-packages/e2e-tests
10991113

11001114
- name: Build E2E app
1101-
working-directory: ${{ runner.temp }}/test-application
1115+
working-directory: dev-packages/tmp-test-application
11021116
timeout-minutes: 7
11031117
run: ${{ matrix.build-command || 'pnpm test:build' }}
11041118

11051119
- name: Run E2E test
1106-
working-directory: ${{ runner.temp }}/test-application
1120+
working-directory: dev-packages/tmp-test-application
11071121
timeout-minutes: 10
11081122
run: ${{ matrix.assert-command || 'pnpm test:assert' }}
11091123

@@ -1117,7 +1131,7 @@ jobs:
11171131
if: failure()
11181132
with:
11191133
name: E2E Test Dump (${{ matrix.label || matrix.test-application }})
1120-
path: ${{ runner.temp }}/test-application/event-dumps
1134+
path: dev-packages/tmp-test-application/event-dumps
11211135
overwrite: true
11221136
retention-days: 7
11231137
if-no-files-found: ignore

.github/workflows/canary.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -173,16 +173,16 @@ jobs:
173173
working-directory: dev-packages/e2e-tests
174174

175175
- name: Copy to temp
176-
run: yarn ci:copy-to-temp ./test-applications/${{ matrix.test-application }} ${{ runner.temp }}/test-application
176+
run: yarn ci:copy-to-temp ./test-applications/${{ matrix.test-application }} ../tmp-test-application
177177
working-directory: dev-packages/e2e-tests
178178

179179
- name: Build E2E app
180-
working-directory: ${{ runner.temp }}/test-application
180+
working-directory: dev-packages/tmp-test-application
181181
timeout-minutes: 7
182182
run: yarn ${{ matrix.build-command }}
183183

184184
- name: Run E2E test
185-
working-directory: ${{ runner.temp }}/test-application
185+
working-directory: dev-packages/tmp-test-application
186186
timeout-minutes: 15
187187
run: yarn test:assert
188188

0 commit comments

Comments
 (0)