ref(*): remove spin from templates, scripts, static/js#1513
Merged
Conversation
|
🚀 preview deployed successfully to Fermyon Cloud and available at https://fermyon-developer-pr-1513-2tgfijox.fermyon.app |
Member
Author
|
Whoops, needs some attention re: the page_lang.hbs template... either can't delete it or need to just remove spin cruft; wasm-languages pages use it edit: brought it back; rm'd spin cruft |
vdice
force-pushed
the
ref/templates-rm-spin
branch
2 times, most recently
from
e691aee to
d491247
Compare
vdice
changed the title
karthik2804
reviewed
Apr 2, 2025
Comment on lines
+48
to
56
| {{#if (active_project request.spin-full-url "/cloud/" )}} | ||
| <a class="navbar-link is-active is-hoverable"> | ||
| <span>Spin</span> | ||
| <span>Cloud</span> | ||
| </a> | ||
| {{else}} | ||
| {{#if (active_project request.spin-full-url "/cloud/" )}} | ||
| {{#if (active_project request.spin-full-url "/wasm-functions/" )}} | ||
| <a class="navbar-link is-active is-hoverable"> | ||
| <span>Cloud</span> | ||
| <span>Wasm Functions</span> | ||
| </a> |
Contributor
There was a problem hiding this comment.
Do we want to present cloud as the top option in the drop down. I do not have strong feelings about this but just wanted to check. oh, I also see it just keeps the same structure as before.
Member
Author
There was a problem hiding this comment.
Right, same order remains; just removed Spin.
2 tasks
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
Signed-off-by: Vaughn Dice <vaughn.dice@fermyon.com>
vdice
force-pushed
the
ref/templates-rm-spin
branch
from
d491247 to
fbca5ed
Compare
karthik2804
approved these changes
Apr 14, 2025
Contributor
|
I am not quire sure what this is doing, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1504
Could probably use reviews by @flynnduism and @karthik2804 especially 🔍
Depends on:
If it helps, here is a deploy incorporating changes from this PR and all of the ones in the list above: https://fermyon-developer-lmc6mnqx.fermyon.app/