chore: Use tsconfig bases #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 19, 2025
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 19, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
=======================================
Coverage 99.78% 99.78%
=======================================
Files 77 77
Lines 1879 1879
Branches 251 251
=======================================
Hits 1875 1875
Misses 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wschurman
approved these changes
Jun 20, 2025
Member
wschurman
left a comment
wschurman
left a comment
There was a problem hiding this comment.
nit: add a test plan. for this, it can just be tsc
| "noImplicitOverride": true, | ||
| "esModuleInterop": true | ||
| "sourceMap": true | ||
| } |
Member
There was a problem hiding this comment.
For posterity, the changes this makes are:
"module": "nodenext",
"skipLibCheck": true,
"moduleResolution": "node16"
"allowUnusedLabels": false,
"allowUnreachableCode": false,
"isolatedModules": true,
"checkJs": true,
I think all of these are fine.
Member
Author
Merge activity
|
nicknovitski
force-pushed
the
graphite-base/296
branch
from
44ecce9 to
fd5597c
Compare
nicknovitski
force-pushed
the
tsconfig-bases
branch
from
a0639b4 to
63d42ad
Compare
nicknovitski
force-pushed
the
tsconfig-bases
branch
from
63d42ad to
adba5fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
These are sensible defaults, so much so that they almost perfectly match what we already set.
Test plan
yarn build