Skip to content

Conversation

@nicknovitski
Copy link
Member

@nicknovitski nicknovitski commented Jun 19, 2025

Why

It's faster, at least locally where we run without coverage instrumentation.

Test Plan

CI.

Copy link
Member Author

nicknovitski commented Jun 19, 2025

@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.78%. Comparing base (1fd0144) to head (fd5597c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          77       77           
  Lines        1879     1879           
  Branches      251      251           
=======================================
  Hits         1875     1875           
  Misses          4        4           
Flag Coverage Δ
integration 99.78% <ø> (ø)
unittest 99.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nicknovitski nicknovitski marked this pull request as ready for review June 19, 2025 20:45
@nicknovitski nicknovitski requested a review from wschurman as a code owner June 19, 2025 20:45
@wschurman wschurman changed the title jest v29.7.0 -> 30.0.0 chore: jest v29.7.0 -> 30.0.0 Jun 20, 2025
Copy link
Member

@wschurman wschurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a test plan (ditto)

Copy link
Member Author

nicknovitski commented Jun 20, 2025

Merge activity

  • Jun 20, 7:07 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 20, 7:15 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jun 20, 7:19 PM UTC: @nicknovitski merged this pull request with Graphite.

@nicknovitski nicknovitski changed the base branch from babel-jest to graphite-base/295 June 20, 2025 19:08
@nicknovitski nicknovitski changed the base branch from graphite-base/295 to main June 20, 2025 19:14
@nicknovitski nicknovitski merged commit 65d50d6 into main Jun 20, 2025
3 checks passed
@nicknovitski nicknovitski deleted the jest-30 branch June 20, 2025 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants