Skip to content

chore: Remove @jest/types#293

Merged
nicknovitski merged 1 commit intomainfrom
jest-types
Jun 20, 2025
Merged

chore: Remove @jest/types#293
nicknovitski merged 1 commit intomainfrom
jest-types

Conversation

@nicknovitski
Copy link
Copy Markdown
Member

@nicknovitski nicknovitski commented Jun 19, 2025

Why

Jest is written in typescript and ships with its own types.

Test Plan

Typecheck and tests running in CI.

Copy link
Copy Markdown
Member Author

nicknovitski commented Jun 19, 2025

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (875cce3) to head (4afe141).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #293   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           82        82           
  Lines         2287      2287           
  Branches       251       251           
=========================================
  Hits          2287      2287           
Flag Coverage Δ
integration 100.00% <ø> (ø)
unittest 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nicknovitski nicknovitski marked this pull request as ready for review June 19, 2025 20:45
@nicknovitski nicknovitski requested a review from wschurman as a code owner June 19, 2025 20:45
@wschurman wschurman changed the title Remove @jest/types chore: Remove @jest/types Jun 20, 2025
Copy link
Copy Markdown
Member

@wschurman wschurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a test plan. for this, it can just be "Run all tests in CI"

Copy link
Copy Markdown
Member Author

nicknovitski commented Jun 20, 2025

Merge activity

  • Jun 20, 7:07 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 20, 7:07 PM UTC: @nicknovitski merged this pull request with Graphite.

@nicknovitski nicknovitski merged commit 6cecd9f into main Jun 20, 2025
4 checks passed
@nicknovitski nicknovitski deleted the jest-types branch June 20, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants