fw/applib/ui/dialogs: fix dialog icon animation offset for wider displays#865
Closed
cyrusagent[bot] wants to merge 1 commit intomainfrom
Closed
fw/applib/ui/dialogs: fix dialog icon animation offset for wider displays#865cyrusagent[bot] wants to merge 1 commit intomainfrom
cyrusagent[bot] wants to merge 1 commit intomainfrom
Conversation
cyrusagent
bot
changed the title
cyrusagent
bot
force-pushed
the
cyrus/firm-1068-shredder-animation-is-misaligned-on-pt2
branch
2 times, most recently
from
d7ebd2e to
20572dc
Compare
…lays The hardcoded DISP_OFFSET of 80 was insufficient for displays wider than 144px (e.g. obelix/robert at 200px), causing the icon slide-in animation to start on-screen instead of off-screen. Use DISP_COLS for the from-right offset and -icon_rect.size.w for the from-left offset to ensure the icon always starts fully off-screen on all display sizes. Fixes FIRM-1068 Signed-Off-By: Gerard Marull-Paretas <gerard@teslabs.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
cyrusagent
bot
force-pushed
the
cyrus/firm-1068-shredder-animation-is-misaligned-on-pt2
branch
from
20572dc to
7db3139
Compare
Member
gmarull
deleted the
cyrus/firm-1068-shredder-animation-is-misaligned-on-pt2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the shredder (and other dialog icon) animation being misaligned on Pebble Time 2 (obelix) and other wider displays.
The hardcoded
DISP_OFFSET = 80indialog_init_icon_layer()was insufficient for displays wider than 144px. On obelix (200px wide), the icon slide-in animation started at x=80, which is well within the visible area instead of off-screen.Changes
DISP_OFFSET = 80with display-aware values:DISP_COLS(display width) so the icon starts just off the right edge-icon_rect.size.wso the icon starts just off the left edgeTesting
obelix_dvt,snowy_bb2, andgetafix_dvtLinear Issue
Fixes FIRM-1068