Skip to content

fw/applib/ui/dialogs: fix dialog icon animation offset for wider displays #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cyrusagent wants to merge 1 commit into from
Closed

fw/applib/ui/dialogs: fix dialog icon animation offset for wider displays #865

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/fw/applib/ui/dialogs/dialog_private.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,12 @@ bool dialog_init_icon_layer(Dialog *dialog, KinoReel *image,
layer_set_clips(&icon_layer->layer, false);

GRect from = icon_rect;
// Animate from off screen. We need to be at least -80, since that is our largest icon size.
const int16_t DISP_OFFSET = 80;
// Animate from off screen. Use display width to ensure icon starts fully off-screen
// on all display sizes (e.g. 200px wide on obelix/robert).
if (dialog->icon_anim_direction == DialogIconAnimationFromLeft) {
from.origin.x = -DISP_OFFSET;
from.origin.x = -icon_rect.size.w;
} else if (dialog->icon_anim_direction == DialogIconAnimationFromRight) {
from.origin.x = DISP_OFFSET;
from.origin.x = DISP_COLS;
}

const int16_t ICON_TARGET_PT_X = icon_rect.size.w;
Expand Down
Loading