fw/applib/ui/dialogs: fix dialog icon animation offset for wider displays

The hardcoded DISP_OFFSET of 80 was insufficient for displays wider than
144px (e.g. obelix/robert at 200px), causing the icon slide-in animation
to start on-screen instead of off-screen. Use DISP_COLS for the from-right
offset and -icon_rect.size.w for the from-left offset to ensure the icon
always starts fully off-screen on all display sizes.

Fixes FIRM-1068

Signed-Off-By: Gerard Marull-Paretas <gerard@teslabs.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: 2 people

src/fw/applib/ui/dialogs/dialog_private.c

@@ -114,12 +114,12 @@ bool dialog_init_icon_layer(Dialog *dialog, KinoReel *image,
   layer_set_clips(&icon_layer->layer, false);
 
   GRect from = icon_rect;
-  // Animate from off screen. We need to be at least -80, since that is our largest icon size.
-  const int16_t DISP_OFFSET = 80;
+  // Animate from off screen. Use display width to ensure icon starts fully off-screen
+  // on all display sizes (e.g. 200px wide on obelix/robert).
   if (dialog->icon_anim_direction == DialogIconAnimationFromLeft) {
-    from.origin.x = -DISP_OFFSET;
+    from.origin.x = -icon_rect.size.w;
   } else if (dialog->icon_anim_direction == DialogIconAnimationFromRight) {
-    from.origin.x = DISP_OFFSET;
+    from.origin.x = DISP_COLS;
   }
 
   const int16_t ICON_TARGET_PT_X = icon_rect.size.w;