Fix 'string builder buffer' can be replaced with 'string' #2415
Closed
Pankraz76 wants to merge 1 commit intoapache:masterfrom
Closed
Fix 'string builder buffer' can be replaced with 'string' #2415Pankraz76 wants to merge 1 commit intoapache:masterfrom
Pankraz76 wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Pankraz76
commented
May 31, 2025
Pankraz76
commented
This was referenced May 31, 2025
Pankraz76
force-pushed
the
fix-'StringBuilder-buffer'-can-be-replaced-with-'String'-
branch
from
8137254 to
93c8da6
Compare
Pankraz76
commented
May 31, 2025
...n-compat/src/main/java/org/apache/maven/artifact/repository/layout/FlatRepositoryLayout.java
Show resolved
Hide resolved
Pankraz76
commented
May 31, 2025
...n-compat/src/main/java/org/apache/maven/artifact/repository/layout/FlatRepositoryLayout.java
Outdated
Show resolved
Hide resolved
Pankraz76
force-pushed
the
fix-'StringBuilder-buffer'-can-be-replaced-with-'String'-
branch
from
93c8da6 to
5ad598d
Compare
Pankraz76
commented
May 31, 2025
| @@ -62,19 +62,11 @@ public String pathOf(Artifact artifact) { | |||
| } | |||
|
|
|||
| public String pathOfLocalRepositoryMetadata(ArtifactMetadata metadata, ArtifactRepository repository) { | |||
Contributor
Author
There was a problem hiding this comment.
might conflict with:
Pankraz76
commented
May 31, 2025
...n-compat/src/main/java/org/apache/maven/artifact/repository/layout/FlatRepositoryLayout.java
Show resolved
Hide resolved
Pankraz76
commented
May 31, 2025
compat/maven-compat/src/test/java/org/apache/maven/project/AbstractMavenProjectTestCase.java
Show resolved
Hide resolved
elharo
requested changes
May 31, 2025
| buffer.append(updatePolicy); | ||
| buffer.append('}'); | ||
| return buffer.toString(); | ||
| return "{enabled=" + enabled + ", checksums=" + checksumPolicy + ", updates=" + updatePolicy + '}'; |
Contributor
There was a problem hiding this comment.
don't do this; it's actively bad
Contributor
Author
There was a problem hiding this comment.
before it was optimized, right?
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.