chore(ci): migrate to trusted publishing#2593
Conversation
dab4520 to
19338bf
Compare
19338bf to
8762e94
Compare
8762e94 to
34501f4
Compare
kevinjqliu
left a comment
There was a problem hiding this comment.
thanks!
looks like we'd have to add trusted publishing to each crate separately. @blackmwk is the common owner for all the crates https://crates.io/users/liurenjie1024
| permissions: | ||
| contents: read | ||
|
|
There was a problem hiding this comment.
nit: could we keep this? it looks redundant but it sets the default permission for all the blocks.
we can add more permissions by explicitly overriding each job
There was a problem hiding this comment.
I'll restore for now.
I think the other thing we could consider is permissions: {} such that every job must have its list of permissions required.
blackmwk
left a comment
There was a problem hiding this comment.
Thanks @dannycjones for this pr, just one same comment as @kevinjqliu .
| permissions: | ||
| contents: read | ||
|
|
|
I've finished crates.io side changes, let's see if it works. |
I'd recommend we create a GH team for the Apache Iceberg committers, as the team can be added to all the crates. You do still need an active committer as the owner, as team members cannot change crate ownership themselves, but it would make it easier to grant permissions across the broad list of crates. |
|
Thanks both, updated to restore the default |
Which issue does this PR close?
This implements trusted publishing with crates.io, which closes #1539. I'd propose to close that issue after the first successful release.
What changes are included in this PR?
This simply migrates the release workflow to use credentials obtained using trusted publishing.
This is the guide followed for the change: https://crates.io/docs/trusted-publishing
This change does not include the required changes on crates.io, which will need a committer to perform. I will add the remaining steps to #1539.
Are these changes tested?
No. The changes will be verified with the first public release.