fix: correct bash syntax in JVM memory floor enforcement #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request – Simulation Only
Summary
Fixes critical bash syntax errors introduced in commit f2633e1 that prevented
setup_minecraft.shandsetup_minecraft_lxc.shfrom executing. The malformed lines concatenated multiple conditions without proper&&operators.Before (broken):
After (corrected):
Also updates memory floor comments from
256M/448Mto1024M/2048Mto match implementation.Checklist
SIMULATION.mdupdated to reflect behavior and risks.Testing (Simulation)
Both scripts pass
bash -nsyntax validation. When executed on a Proxmox VM/LXC:/opt/minecraft💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.