Skip to content

fix: correct bash syntax in JVM memory floor enforcement #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TimInTech merged 2 commits into from
Nov 8, 2025
Merged

fix: correct bash syntax in JVM memory floor enforcement #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
271ced7
Initial plan
Copilot Nov 8, 2025
70206aa
fix(setup): correct bash syntax for JVM memory floor checks
Copilot Nov 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions setup_minecraft.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@ cd /opt/minecraft

printf '%s\n' "eula=true" > eula.txt

# Autosize memory: Xms=RAM/4, Xmx=RAM/2; floors 256M/448M; cap Xmx ≤16G.
# Autosize memory: Xms=RAM/4, Xmx=RAM/2; floors 1024M/2048M; cap Xmx ≤16G.
mem_kb=$(awk '/MemTotal/ {print $2}' /proc/meminfo); mem_mb=$((mem_kb/1024))
xmx=$(( mem_mb/2 ))
(( xmx < 2048 )) (( xmx < 448 )) && xmx=448(( xmx < 448 )) && xmx=448 xmx=2048
(( xmx < 2048 )) && xmx=2048
(( xmx > 16384 )) && xmx=16384
xms=$(( mem_mb/4 ))
(( xms < 1024 )) (( xms < 256 )) && xms=256(( xms < 256 )) && xms=256 xms=1024
(( xms < 1024 )) && xms=1024
(( xms > xmx )) && xms=$xmx

# Download latest PaperMC with SHA256 verification and min-size check (>5MB).
Expand Down
6 changes: 3 additions & 3 deletions setup_minecraft_lxc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@ cd /opt/minecraft

printf '%s\n' "eula=true" > eula.txt

# Autosize memory: Xms=RAM/4, Xmx=RAM/2; floors 256M/448M; cap Xmx ≤16G.
# Autosize memory: Xms=RAM/4, Xmx=RAM/2; floors 1024M/2048M; cap Xmx ≤16G.
mem_kb=$(awk '/MemTotal/ {print $2}' /proc/meminfo); mem_mb=$((mem_kb/1024))
xmx=$(( mem_mb/2 ))
(( xmx < 2048 )) (( xmx < 448 )) && xmx=448(( xmx < 448 )) && xmx=448 xmx=2048
(( xmx < 2048 )) && xmx=2048
(( xmx > 16384 )) && xmx=16384
xms=$(( mem_mb/4 ))
(( xms < 1024 )) (( xms < 256 )) && xms=256(( xms < 256 )) && xms=256 xms=1024
(( xms < 1024 )) && xms=1024
(( xms > xmx )) && xms=$xmx

# Download latest PaperMC with SHA256 verification and min-size check (>5MB).
Expand Down