feat: raise JVM memory floors (Xms≥1G, Xmx≥2G) #56
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to update memory configuration thresholds and fix a URL format in the README, but introduces critical syntax errors that will prevent the scripts from executing.
- Updates minimum memory allocations for Minecraft server (Xms from 256M to 1024M, Xmx from 448M to 2048M)
- Changes GitHub issues URL format from git@ to https:// format
- Contains severe bash syntax errors that prevent script execution
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| setup_minecraft_lxc.sh | Attempts to update memory floor values but introduces bash syntax errors on lines 30 and 33 |
| setup_minecraft.sh | Attempts to update memory floor values but introduces identical bash syntax errors on lines 30 and 33 |
| README.md | Updates GitHub issues URL from git@ format to https:// format |
|
@copilot open a new pull request to apply changes based on the comments in this thread |
1 similar comment
|
@copilot open a new pull request to apply changes based on the comments in this thread |
|
@TimInTech I've opened a new pull request, #58, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@TimInTech I've opened a new pull request, #59, to work on those changes. Once the pull request is ready, I'll request review from you. |
* Initial plan * fix(setup): correct bash syntax for JVM memory floor checks Co-authored-by: TimInTech <129355283+TimInTech@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TimInTech <129355283+TimInTech@users.noreply.github.com>
* Initial plan * fix: correct bash syntax errors in memory floor assignments Co-authored-by: TimInTech <129355283+TimInTech@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TimInTech <129355283+TimInTech@users.noreply.github.com>
This reverts commit 3f8debf.
Prevents undersized JVM on low-RAM hosts; keeps cap at ≤16G.