fix: correct bash syntax in JVM memory floor assignments #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request – Simulation Only
Summary
Fixes malformed bash syntax in memory floor assignments introduced in previous commit. Lines 30 and 33 in both
setup_minecraft.shandsetup_minecraft_lxc.shcontained corrupted condition chains lacking&&operators, causing syntax errors at runtime.Before:
After:
Updated comment to reflect actual floors:
1024M/2048M(was256M/448M).Checklist
SIMULATION.mdupdated to reflect behavior and risks.Testing (Simulation)
Validated with
bash -n(syntax check) andshellcheck(zero warnings). Scripts now parse correctly and will enforce 1G minimum heap / 2G minimum max heap when executed on target Proxmox VM/LXC hosts. No behavioral change beyond raising the memory floors as intended by original PR.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.