Skip to content

Migrate moveit_studio_package() to moveit_pro_package()#533

Merged
JWhitleyWork merged 1 commit intov9.1from
dave/migrate-moveit-pro-package
Mar 19, 2026
Merged

Migrate moveit_studio_package() to moveit_pro_package()#533
JWhitleyWork merged 1 commit intov9.1from
dave/migrate-moveit-pro-package

Conversation

@davetcoleman
Copy link
Member

Summary

  • Migrate lab_sim_behaviors and example_behaviors from the deprecated moveit_studio_package() CMake macro to moveit_pro_package()
  • Update <build_depend> in both package.xml files from moveit_studio_common to moveit_pro_package

This eliminates the CMake deprecation warnings emitted during user workspace builds against MoveIt Pro 9.1.0+.

Note: moveit_studio_ur_pstop_manager (in the moveit_pro_ur_configs subtree) also uses the deprecated macro but lives in a separate repo — that fix should be done there.

Resolves PickNikRobotics/moveit_pro#17594

Test plan

  • Build the example workspace: colcon build --packages-up-to lab_sim_behaviors example_behaviors
  • Verify no deprecation warnings in stderr output

🤖 Generated with Claude Code

Update lab_sim_behaviors and example_behaviors to use the new
moveit_pro_package() CMake macro and moveit_pro_package build
dependency, replacing the deprecated moveit_studio_common/
moveit_studio_package() equivalents.

Resolves PickNikRobotics/moveit_pro#17594

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@davetcoleman davetcoleman force-pushed the dave/migrate-moveit-pro-package branch from 8d6f4f6 to e92d98f Compare March 18, 2026 22:53
@davetcoleman davetcoleman marked this pull request as ready for review March 18, 2026 22:57
JWhitleyWork
JWhitleyWork previously approved these changes Mar 18, 2026
Copy link
Member

@JWhitleyWork JWhitleyWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@davetcoleman
Copy link
Member Author

I'm just realizing I wanted to target this to 9.1, as i saw this issue in the RC-2 release. is it ok if its retargetted? if so, can you do that while Im out the next... week, please?

@JWhitleyWork JWhitleyWork changed the base branch from main to v9.1 March 19, 2026 15:12
@JWhitleyWork JWhitleyWork dismissed their stale review March 19, 2026 15:12

The base branch was changed.

@JWhitleyWork JWhitleyWork merged commit ba1f3e1 into v9.1 Mar 19, 2026
5 checks passed
@JWhitleyWork JWhitleyWork deleted the dave/migrate-moveit-pro-package branch March 19, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants