Migrate moveit_studio_package() to moveit_pro_package()#533
Merged
JWhitleyWork merged 1 commit intov9.1from Mar 19, 2026
Merged
Migrate moveit_studio_package() to moveit_pro_package()#533JWhitleyWork merged 1 commit intov9.1from
JWhitleyWork merged 1 commit intov9.1from
Conversation
Update lab_sim_behaviors and example_behaviors to use the new moveit_pro_package() CMake macro and moveit_pro_package build dependency, replacing the deprecated moveit_studio_common/ moveit_studio_package() equivalents. Resolves PickNikRobotics/moveit_pro#17594 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
8d6f4f6 to
e92d98f
Compare
Member
Author
|
I'm just realizing I wanted to target this to 9.1, as i saw this issue in the RC-2 release. is it ok if its retargetted? if so, can you do that while Im out the next... week, please? |
JWhitleyWork
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lab_sim_behaviorsandexample_behaviorsfrom the deprecatedmoveit_studio_package()CMake macro tomoveit_pro_package()<build_depend>in bothpackage.xmlfiles frommoveit_studio_commontomoveit_pro_packageThis eliminates the CMake deprecation warnings emitted during user workspace builds against MoveIt Pro 9.1.0+.
Note:
moveit_studio_ur_pstop_manager(in themoveit_pro_ur_configssubtree) also uses the deprecated macro but lives in a separate repo — that fix should be done there.Resolves PickNikRobotics/moveit_pro#17594
Test plan
colcon build --packages-up-to lab_sim_behaviors example_behaviors🤖 Generated with Claude Code