Add lab desk objects, AprilTag bottle picking, and clean up lab_sim#512
Add lab desk objects, AprilTag bottle picking, and clean up lab_sim#512davetcoleman wants to merge 2 commits intomainfrom
Conversation
ff401c8 to
4cee822
Compare
17e3dc9 to
f06197a
Compare
b621d9c to
6c53a30
Compare
|
This is failing CI for both integration testing and pre-commit. Please confirm the objectives in lab_sim still run successfully and that the new assets don't introduce any unexpected behaviors (ungraspable objects due to collisions, collisions with new objects due to waypoints, confusing input to ML prompts, poor friction coefficient for new objects). As our flagship config, I wouldn't want to introduce a whole bunch of unpickable objects or add complexity that would make the product look poorly functional. Please also monitor the change in CPU usage, there are a lot of additional free joints that would significantly increase the CPU load and I want to make sure it's not a huge jump. I noticed some of the free joints (like the alligator) are not even reachable, and would be better as fixed joints. When this PR is tested and ready for review, please add a story to track your work on the project board |
a3d0b64 to
456c578
Compare
rlpratt12
left a comment
There was a problem hiding this comment.
This includes custom behaviors, mujoco scene changes, and modified/new objectives. Please break these changes in to multiple PRs per our best practices.
|
@rlpratt12 as stated in the comment above (#512 (comment)) and in the PR desc, I have this effort broken into 4 PRs already, two of which are in this combined PR temporarily. I can break it into more, but I first need the earlier PRs merged in. Managing 4 PRs across 3 repos is a huge pain, and you are unfairly characterizing my efforts here. |
5b89b7a to
1c644c2
Compare
|
I've had claude split this out into more PRs, that are all straight forward and ready to merge asap:
This final PR I've marked as draft until those other ones are merged. |
1c644c2 to
adf2fbd
Compare
adf2fbd to
71b922b
Compare
|
Rebased to pick up CI fix. |
71b922b to
272662c
Compare
272662c to
eb6eccb
Compare
… up lab_sim Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@nbbrooks merged the last blocker PR (of several) to this late yesterday, so can we merge this now? |
eb6eccb to
3de8f92
Compare
|
@rlpratt12 can you remove your "requested changes" block? @davetcoleman am I missing a countertop texture? or is that a followup pr?
|
|
My laptop is having performance issues and I'm seeing a 50% grasp success rate. simplescreenrecorder-2026-03-13_08.44.45.mp4This could be any number of things
I am concerned people in training will run into this, but I don't have a good grasp on the success rate for the current set of objectives. I suspect the EGL rendering will vastly improve this by taking off CPU load. |
|
I wasn't able to get ML working on my GPU so I haven't tested the ML objectives, but I've updated the PR summary to include a list of objectives and whether they still run successfully or not. I've made some easy fixes, but some of the objectives require larger efforts to fix (new ICP/registration examples, update/remove/replace hardcoded pick and place objectives, shift pose-based paths so they dont collide with new desk location). My latest changes are pushed, but I'd like someone else to confirm the failing objectives are now passing for them as well |
This is the texture Claude gave me for the countertop, and I was actually happy with it. You're hoping for a non-checkerboard black pattern? How about we leave that for future work.
This is why I had added ForceSuccess, and I had tuned the gripper config further, and I had changed the close amount to be less than the full close distance. But those changes were asked to be reverted through the review process thus far.
I don't see your fixes in this PR's force push history, are you sure you pushed them @MikeWrock ? |
Let's separate out physical grasping success concerns from |

Summary
TODO
Dependencies
Note: I would love to get rid of picknik_accessories repo for good, merging it into this repo. With the advent of AI, we dont need to maintain a reusable set of MuJoCo assets for our customers. The vision was to make this into a sharable library I think. In a future PR, I think we should get rid of this repo because it causes a lot of problems trying to keep changes to moveit_pro, example_ws, and picknik_accessories in sync.
Passing Objectives (per @MikeWrock's test)
Application - Advanced Examples
Application - Basic Examples
Application - ML (GPU Recommended)
Application - MPC Examples
Grasping
Motion - Execute
Motion - Planning
MuJoCo Simulation
Perception - 3D Point Cloud
Perception - Planning Scene
Perception - Scene Constraints
Training Examples
User Input
Vector Handling
Visualization