Coverage reporting refactor and cleanup#397
Conversation
de82f8e to
6912510
Compare
62bc579 to
231bbd9
Compare
8b40a0f to
ff18080
Compare
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
astrofrog
left a comment
There was a problem hiding this comment.
This seems ok to me! Did you test it out on a real package? If so feel free to merge.
No combining may be needed
|
I'm having trouble with it on sunpy: sunpy/sunpy#8665 |
|
Do people think it's worth throwing a warning about the |
I would say, yes. Not everyone follows the PRs here or even read the change log. |
|
Ok, done, and failing test added to demo. I think this is ready, I'll put out a 3.0 after this. |
pllim
left a comment
There was a problem hiding this comment.
I have a comment and a question.
|
So you just gonna leave the |
yep lol |
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
|
|
fixes #395 and fixes #383
This PR makes the following changes:
setenv = COVERAGE_FILE={toxinidir}/.coverageintox.iniif your tests are not run in the{toxinidir}directory, so that reporting finds the.coveragefile.coverage: codecovno longer requires the use ofpytest-cov, the xml coverage report is generated using coverage.py in a separate step to the tox run.CODECOV_TOKENif using this.coverage: githubis now tested against both pytest-cov and coverage.py, and as long as the.coveragefiles are in the root directory will work correctly.