Skip to content

Do not explicitly specify uv version in calls to setup-uv#396

Merged
Cadair merged 2 commits into
OpenAstronomy:mainfrom
Cadair:uv_version
Jun 3, 2026
Merged

Do not explicitly specify uv version in calls to setup-uv#396
Cadair merged 2 commits into
OpenAstronomy:mainfrom
Cadair:uv_version

Conversation

@Cadair
Copy link
Copy Markdown
Member

@Cadair Cadair commented Jun 3, 2026

I'm not entirely sure why these versions were here, I don't think we want to pin it, latest should be fine?

@Cadair Cadair changed the title Python Version trickery Do not explicitly specify uv version in calls to setup-uv Jun 3, 2026
@Cadair Cadair requested a review from zacharyburnett June 3, 2026 09:09
@zacharyburnett
Copy link
Copy Markdown
Contributor

IMO it would be better to have reproducibility, since uv is still under active development and is not yet at 1.0.0 (just in case a new uv version breaks something)

@Cadair
Copy link
Copy Markdown
Member Author

Cadair commented Jun 3, 2026

I kind of feel like if we can't trust latest release of uv then that's a good reason not to use it.

The motivation for this is trying to figure out why uv isn't installing the latest bugfix release of 3.14 e.g. here.

I think if we are going to pin this, I'd be nice to both have a reminder to update it, and also a way for users to override it.

@zacharyburnett
Copy link
Copy Markdown
Contributor

that's a good point, I haven't seen a case where a uv update breaks existing CI, and setup-uv is being used in a lot of other projects without pinning the uv version, so it seems good to trust

@Cadair
Copy link
Copy Markdown
Member Author

Cadair commented Jun 3, 2026

Are you good with merging this and #397 and putting them both out as a 3.0?

@zacharyburnett
Copy link
Copy Markdown
Contributor

Are you good with merging this and #397 and putting them both out as a 3.0?

Sure, but could we consider #392 as well if we're doing a major version bump?

@Cadair Cadair merged commit 6a5d787 into OpenAstronomy:main Jun 3, 2026
84 checks passed
@Cadair Cadair deleted the uv_version branch June 3, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants