Skip to content

replace fill: parameter with logic to expand py3* glob syntax in envs#392

Open
zacharyburnett wants to merge 7 commits into
OpenAstronomy:mainfrom
zacharyburnett:python_version_glob
Open

replace fill: parameter with logic to expand py3* glob syntax in envs#392
zacharyburnett wants to merge 7 commits into
OpenAstronomy:mainfrom
zacharyburnett:python_version_glob

Conversation

@zacharyburnett
Copy link
Copy Markdown
Contributor

@zacharyburnett zacharyburnett commented May 5, 2026

as this change removes a parameter it will require a major version bump

better solution for #325 than #326

replaces the fill: parameter with just specifying py3* or py31* in the env name to expand into supported Python versions; I should have done this originally in #326 😅

this change also moves supported_pythons.py into tox_matrix.py

@zacharyburnett zacharyburnett force-pushed the python_version_glob branch 4 times, most recently from 8b2b1e3 to a39e3c1 Compare May 5, 2026 15:08
@zacharyburnett zacharyburnett marked this pull request as ready for review May 5, 2026 15:19
@zacharyburnett
Copy link
Copy Markdown
Contributor Author

the automated tests failed yesterday due to YET ANOTHER github outage 🙄 I'll try to rerun them

@zacharyburnett zacharyburnett changed the title replace fill: parameter with logic to expand py3* glob syntax in envs replace fill: parameter with logic to expand py3* glob syntax in envs May 6, 2026
@zacharyburnett zacharyburnett force-pushed the python_version_glob branch 3 times, most recently from d0c66b2 to dd09c54 Compare May 8, 2026 19:04
@zacharyburnett zacharyburnett marked this pull request as draft May 27, 2026 18:21
@zacharyburnett zacharyburnett marked this pull request as ready for review May 29, 2026 17:51
@zacharyburnett zacharyburnett marked this pull request as draft May 29, 2026 17:51
@zacharyburnett zacharyburnett force-pushed the python_version_glob branch 13 times, most recently from 72d818c to 1d8cac5 Compare June 3, 2026 16:50
@zacharyburnett zacharyburnett marked this pull request as ready for review June 3, 2026 16:50
@zacharyburnett zacharyburnett marked this pull request as draft June 3, 2026 16:56
@zacharyburnett
Copy link
Copy Markdown
Contributor Author

standby, I need to clean this up a bit and then it'll be ready

@zacharyburnett zacharyburnett marked this pull request as ready for review June 3, 2026 16:58
@zacharyburnett
Copy link
Copy Markdown
Contributor Author

there, done

Comment thread .github/workflows/tox.yml Outdated
@zacharyburnett
Copy link
Copy Markdown
Contributor Author

this moves the "retrieve latest Python versions list from the Internet" functionality from supported_pythons.py to the zacharyburnett/supported-pythons action. I've published this version of supported-pythons to the github actions marketplace, so it should be unaffected if I leave STScI or delete my account or whatever; however, we can also move the entire action repo to OpenAstronomy/supported-pythons if that's preferable

Comment thread docs/source/tox.rst
Comment thread tools/tox_matrix.py Outdated
Comment thread docs/source/tox.rst Outdated
Comment thread docs/source/tox.rst Outdated
Comment thread docs/source/tox.rst Outdated
@Cadair
Copy link
Copy Markdown
Member

Cadair commented Jun 3, 2026

I merged #397 and now it needs a rebase sorry 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants