Skip to content

Improved Superficial velocity calculation with paraview#135

Merged
malihass merged 15 commits intomainfrom
syntwarning
Sep 17, 2025
Merged

Improved Superficial velocity calculation with paraview#135
malihass merged 15 commits intomainfrom
syntwarning

Conversation

@malihass
Copy link
Collaborator

@malihass malihass commented Sep 16, 2025

Use paraview module to extract slice at midpoint in the liquid phase and average gas velocity over the slice
A volume flow rate through the slice is computed and divided by the surface area of the slice.
The creation of the slice is best done with paraview which requires modifying a little bit how the installation is done.

This is how the superficial velocity is traditionally computed. The previous implementation was approximating this operation.

I ran tests with the bubble column tutorial at times 0.5, 0.6, 0.7, 0.8
The old method gives [0.002272, 0.001821, 0.002458, 0.002894] and takes 0.32s to run on a Kestrel CPU.
The new one gives [0.002271, 0.00182, 0.002455, 0.002888] and takes 0.88s to run on a Kestrel CPU.

The default behavior is still to use the old method and a parameter use_pv allows to use paraview.

@malihass malihass marked this pull request as draft September 16, 2025 17:44
@malihass malihass changed the title Syntwarning Improved Superficial velocity calculation with paraview Sep 16, 2025
@malihass malihass requested a review from hsitaram September 16, 2025 19:00
@malihass malihass marked this pull request as ready for review September 16, 2025 19:00
@malihass malihass merged commit 1235230 into main Sep 17, 2025
11 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 17, 2025
Improved Superficial velocity calculation with paraview
@malihass malihass deleted the syntwarning branch September 23, 2025 16:59
github-actions bot pushed a commit that referenced this pull request Sep 23, 2025
Improved Superficial velocity calculation with paraview
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant