Conversation
syncup to avoid failing the ci every time
malihass
requested changes
May 21, 2025
Collaborator
malihass
left a comment
malihass
left a comment
There was a problem hiding this comment.
Thanks for adding this
- For passing the linting step, you can activate the bird conda env, and go to the root of the GitHub repo (
${BIRD_DIR}/..) and dobash fixFormat.sh. - The
from paraview import XXXwill not work currently. Can you add that that dependency requirements in BiRD? I suspect it will be tricky to add because of all the c++ bindings in pvpython. In that case, maybe we should think about using the utilities inbird/utilities/ofio.pyinstead, or is there a specific need to stick to pvpython? - Before we can merge, we would need a test. The test would go into
tests/postprocessand you can usetest_cond_mean.pyas an example for that test.
Collaborator
|
Fixed by 7069e23 |
Collaborator
|
paraview dependencies added in #135 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.