Open
Conversation
chore: remove temporary `franka_description` and `foam` submodules
jcarpinelli-bdai
left a comment
jcarpinelli-bdai
left a comment
There was a problem hiding this comment.
I think the .gitmodules should be removed since it is empty!
claytonwramsey
requested changes
Dec 17, 2025
Member
claytonwramsey
left a comment
claytonwramsey
left a comment
There was a problem hiding this comment.
This seems correct to me. My only request: can we add a test script for making sure the implementation is correct? Maybe the random cage dance script from #57 is all that's needed though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Franka FR3 resources and
cricketcomilation output are now available invamp.