Skip to content

Bump actions/checkout from 1 to 4#10383

Merged
yhabteab merged 2 commits intomasterfrom
dependabot/github_actions/actions/checkout-4
May 16, 2025
Merged

Bump actions/checkout from 1 to 4#10383
yhabteab merged 2 commits intomasterfrom
dependabot/github_actions/actions/checkout-4

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 17, 2025

Bumps actions/checkout from 1 to 4.

Release notes

Sourced from actions/checkout's releases.

v4.0.0

What's Changed

New Contributors

Full Changelog: actions/checkout@v3...v4.0.0

v3.6.0

What's Changed

New Contributors

Full Changelog: actions/checkout@v3.5.3...v3.6.0

v3.5.3

What's Changed

New Contributors

Full Changelog: actions/checkout@v3...v3.5.3

v3.5.2

What's Changed

Full Changelog: actions/checkout@v3.5.1...v3.5.2

v3.5.1

What's Changed

New Contributors

... (truncated)

Changelog

Sourced from actions/checkout's changelog.

Changelog

v4.2.2

v4.2.1

v4.2.0

v4.1.7

v4.1.6

v4.1.5

v4.1.4

v4.1.3

v4.1.2

v4.1.1

v4.1.0

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Mar 17, 2025
@cla-bot cla-bot bot added the cla/signed label Mar 17, 2025
Al2Klimov
Al2Klimov previously approved these changes Mar 17, 2025
@Al2Klimov Al2Klimov self-assigned this Mar 17, 2025
@Al2Klimov Al2Klimov marked this pull request as draft March 18, 2025 10:05
@Al2Klimov
Copy link
Member

@dependabot rebase

@Al2Klimov Al2Klimov marked this pull request as ready for review May 5, 2025 09:57
@Al2Klimov Al2Klimov removed their assignment May 5, 2025
@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/checkout-4 branch from 12dd7af to ed78d51 Compare May 5, 2025 09:57
@Al2Klimov
Copy link
Member

Damn, on @dependabot's PRs grep exits non-successfully now! This should fix it:

--- a/.github/workflows/authors-file.yml
+++ b/.github/workflows/authors-file.yml
@@ -18,3 +18,3 @@ jobs:
         run: |
-          set -exo pipefail
+          set -x
           sort -uo AUTHORS AUTHORS

@julianbrost
Copy link
Member

Please try to avoid removing the error handling for the whole script just because a single command is allowed wo fail with an error. You could also consider using sed instead of grep (that shouldn't report in its exit code whether a match was found or not).

@Al2Klimov
Copy link
Member

You're right. A subshell and/or ||true should be also sufficient btw. But I'll leave it up to you..

@Al2Klimov
Copy link
Member

consider using sed instead of grep

Rather perl, I guess:

@julianbrost
Copy link
Member

I don't immediately see why that should be neccessary.

  1. Your reference was about sed -i '...' $filename that seemed to be incompatible with your operating system. Here, | sed '...' should suffice.
  2. This is about GitHub Actions which runs in a defined environment (Ubuntu).

@julianbrost
Copy link
Member

Retry didn't fix the Windows jobs and they still work fine in other PRs, so that failure might actually be related to some change in actions/checkout.

Screenshot of a number of recent Windows workflows. This PR is the only failed one between 10 successful ones.

@Al2Klimov
Copy link
Member

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 16, 2025

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@Al2Klimov Al2Klimov force-pushed the dependabot/github_actions/actions/checkout-4 branch from 937610e to 12dd7af Compare May 16, 2025 08:43
@yhabteab
Copy link
Member

@dependabot recreate

@Al2Klimov
Copy link
Member

What was this for?

@dependabot dependabot bot force-pushed the dependabot/github_actions/actions/checkout-4 branch from 12dd7af to 94cac74 Compare May 16, 2025 08:49
@yhabteab
Copy link
Member

What was this for?

Because I don't know what you did with https://github.com/Icinga/icinga2/compare/937610e270ff4edae6d45d74ee6862c4c2d6f876..12dd7af2c404e07e567e9b91eed0b51ee330ad22 but not rebase!

@Al2Klimov
Copy link
Member

Al2Klimov commented May 16, 2025

TODO

@Al2Klimov Al2Klimov marked this pull request as draft May 16, 2025 08:58
dependabot bot and others added 2 commits May 16, 2025 11:33
Bumps [actions/checkout](https://github.com/actions/checkout) from 1 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v1...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@yhabteab yhabteab force-pushed the dependabot/github_actions/actions/checkout-4 branch from 94cac74 to ef63f43 Compare May 16, 2025 09:35
@Al2Klimov Al2Klimov marked this pull request as ready for review May 16, 2025 09:36
@yhabteab yhabteab added this to the 2.15.0 milestone May 16, 2025
@yhabteab yhabteab merged commit 98ed1b5 into master May 16, 2025
26 checks passed
@yhabteab yhabteab deleted the dependabot/github_actions/actions/checkout-4 branch May 16, 2025 12:23
@yhabteab yhabteab added the backport-to-support/2.14 PRs with this label will automatically be backported to the v2.14 support branch. label Nov 28, 2025
@backbot-ci
Copy link

backbot-ci bot commented Nov 28, 2025

Successfully created backport PR for support/2.14:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-support/2.14 PRs with this label will automatically be backported to the v2.14 support branch. cla/signed dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants