Skip to content

GHA: Fetch full git history for windows#10440

Closed
yhabteab wants to merge 1 commit intomasterfrom
fetch-full-git-history
Closed

GHA: Fetch full git history for windows#10440
yhabteab wants to merge 1 commit intomasterfrom
fetch-full-git-history

Conversation

@yhabteab
Copy link
Member

Quote from https://github.com/actions/checkout:

Only a single commit is fetched by default, for the ref/SHA that triggered the workflow. Set fetch-depth: 0 to fetch all history for all branches and tags

Fixes the Windows GHA from #10383:
https://github.com/Icinga/icinga2/actions/runs/15064535939/job/42346335042?pr=10383

C:\a\icinga2\icinga2\Build_CPack_Packages\win32\WIX\main.wxs(8) : error CNDL0108 : The Product/@Version attribute's value, '083ab56', is not a valid version. Legal version values should look like 'x.x.x.x' where x is an integer from 0 to 65534.

C:\a\icinga2\icinga2\Build_CPack_Packages\win32\WIX\main.wxs(8) : error CNDL0010 : The Product/@Version attribute was not found; it is required.

@cla-bot cla-bot bot added the cla/signed label May 16, 2025
@yhabteab yhabteab requested a review from julianbrost May 16, 2025 09:19
@yhabteab yhabteab added the area/ci CI/CD label May 16, 2025
@yhabteab yhabteab added this to the 2.15.0 milestone May 16, 2025
@julianbrost
Copy link
Member

I'm not sure how much sense this makes as a separate PR instead of pushing this to #10383 directly, that's where the testing for whether it fixes that problem would happen anyway.

@yhabteab yhabteab removed the request for review from julianbrost May 16, 2025 09:31
@yhabteab yhabteab removed this from the 2.15.0 milestone May 16, 2025
@yhabteab yhabteab closed this May 16, 2025
@yhabteab yhabteab deleted the fetch-full-git-history branch May 16, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants