Skip to content

GitHub Actions: Show log files in Windows jobs#10433

Merged
yhabteab merged 1 commit intomasterfrom
gha-windows-logs-artifacts
May 16, 2025
Merged

GitHub Actions: Show log files in Windows jobs#10433
yhabteab merged 1 commit intomasterfrom
gha-windows-logs-artifacts

Conversation

@julianbrost
Copy link
Member

@julianbrost julianbrost commented May 14, 2025

If CPack fails, it may write the actual errors to a dedicated log file:

EXEC : CPack error : Problem running WiX. Please check 'D:/a/icinga2/icinga2/Build/_CPack_Packages/win64/WIX/wix.log' for errors. [D:\a\icinga2\icinga2\Build\PACKAGE.vcxproj]

Show all *.log files as part of the job output so that it doesn't get lost. I've chosen that generic pattern because I don't know whether the exact name and path may change. At the moment, it additionally includes a second file containing some more verbose output from our test cases.

I've made it part of the output as in case of the WIX error log, that's where I'd have expected it in the first place. The output is automatically grouped using some magic GitHub syntax.

Preview of the job output:

refs #10383 (had a pipeline with such an error)

@cla-bot cla-bot bot added the cla/signed label May 14, 2025
@julianbrost julianbrost force-pushed the gha-windows-logs-artifacts branch 2 times, most recently from 2b1c31f to 376c52c Compare May 14, 2025 12:04
If CPack fails, it may write the actual errors to a dedicated log file:

    EXEC : CPack error : Problem running WiX. Please check 'D:/a/icinga2/icinga2/Build/_CPack_Packages/win64/WIX/wix.log' for errors. [D:\a\icinga2\icinga2\Build\PACKAGE.vcxproj]

Show all `*.log` files as part of the job output so that it doesn't get lost.
@julianbrost julianbrost force-pushed the gha-windows-logs-artifacts branch from 376c52c to 5a464af Compare May 14, 2025 12:08
@julianbrost julianbrost added the area/ci CI/CD label May 14, 2025
@julianbrost julianbrost changed the title GitHub Actions: Upload logs from Windows jobs as artifacts GitHub Actions: Show log files in Windows jobs May 14, 2025
@julianbrost julianbrost marked this pull request as ready for review May 14, 2025 13:12
@yhabteab yhabteab added this to the 2.15.0 milestone May 16, 2025
@yhabteab yhabteab merged commit d1f0ffe into master May 16, 2025
45 of 46 checks passed
@yhabteab yhabteab deleted the gha-windows-logs-artifacts branch May 16, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants