Skip to content

Comments

Set a configurable client/server installation password#27

Merged
kostyanf14 merged 1 commit intoHCK-CI:masterfrom
menli820:VIRTWINKVM-1829
Nov 18, 2025
Merged

Set a configurable client/server installation password#27
kostyanf14 merged 1 commit intoHCK-CI:masterfrom
menli820:VIRTWINKVM-1829

Conversation

@menli820
Copy link
Contributor

@menli820 menli820 commented Nov 14, 2025

Set a configurable HLK-client and HLK-server
installation password, default to 'Assentor01'.

depend on: HCK-CI/AutoHCK#799
HCK-CI/AutoHCK-Installer#44

@gemini-code-assist
Copy link

Summary of Changes

Hello @menli820, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the security and flexibility of HLK-client and HLK-server installations by allowing the installation password to be configurable. It replaces a hardcoded password in the unattended setup XML with a dynamic placeholder, whose default value is now defined in a PowerShell example script. This change facilitates easier customization and management of installation security, moving away from static, embedded credentials.

Highlights

  • Configurable Installation Password: Introduced a configurable password for HLK-client and HLK-server installations, replacing a previously hardcoded value.
  • Password Placeholder: The unattend.xml.in file now uses a placeholder @DEFAULT_PASSWORD@ instead of a fixed string for both auto-logon and administrator passwords.
  • Default Password Variable: A new variable $DEFAULTPASSWORD has been added to args.ps1.example, setting the default installation password to 'Assentor01'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a configurable password for the HLK client and server installation, replacing a hardcoded value. This is a good improvement for security and flexibility. However, I have identified a critical security vulnerability where the administrator password is still stored in plaintext in the unattend.xml file. I've also noted that the new default password is weak. My review includes suggestions to address these security concerns.

Set a configurable HLK-client and HLK-server
installation password, default to 'Assentor01'.

Signed-off-by: menli <menli@redhat.com>
@kostyanf14 kostyanf14 merged commit 0cd48c2 into HCK-CI:master Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants