VIRTWINKVM-1829: Set a configurable client/server installation password

[menli820]

depend on: HCK-CI/HLK-Setup-Scripts#27 and HCK-CI/AutoHCK#799

[gemini-code-assist]

Summary of Changes

Hello @menli820, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a new feature that allows users to configure a password for the HLK Studio during the installation process. It provides flexibility by enabling the password to be supplied either through an environment variable or interactively via a prompt, with an option to use a default if no input is given. The change ensures that this password is correctly captured and applied within the system's configuration.

Highlights

• Configurable Studio Password: Introduced the ability to set an optional password for the HLK Studio component during installation, enhancing security and customization.
• New Helper Function: Added a new shell helper function, from_env_or_read_optional, to gracefully handle optional environment variables with interactive prompts, allowing users to accept defaults or provide custom values.
• Installation Integration: Integrated the new password configuration into the installation script, ensuring the provided password is saved to the bootstrap script and subsequently used in the config.json.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a configurable password for the client/server installation. The changes are implemented across three shell scripts to read the optional password, and conditionally include it in a JSON configuration file. The overall approach is sound. My review includes suggestions to improve the code's readability and maintainability. Specifically, I've recommended refactoring a new helper function in helpers.sh to reduce complexity and duplication, and to fix variable scoping issues. I've also suggested reformatting a jq expression in config.sh to make it more understandable.

[menli820]

bash install.sh
Please provide path to repos directory: /home/lll
Please provide path to ISO directory: /home/hck/iso
Please provide path to images directory: /home/hck/images
Please provide path to workspace directory: /home/hck/workspace
Please provide HLK Studio password (or press Enter to use default):

@kostyanf14 please help review it, thanks