Set a configurable client/server installation password#799
Set a configurable client/server installation password#799kostyanf14 merged 1 commit intoHCK-CI:masterfrom
Conversation
Summary of ChangesHello @menli820, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the installation process for HLK (Hardware Lab Kit) environments by introducing a configurable password mechanism for both client and server installations. It updates the default password to 'Assentor01' and provides a flexible way to override this default by reading a password from an external Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a configurable installation password for HLK-client and HLK-server, with a new default. My review focuses on security and code quality. I've pointed out a security risk with the hardcoded default password in config.json. I've also suggested a significant refactoring of the new read_password_from_args method in lib/engines/hckinstall/hckinstall.rb to improve its efficiency, robustness, and to follow common conventions.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
lib/engines/hckinstall/hckinstall.rb
Outdated
| end | ||
|
|
||
| def read_password_from_args | ||
| args_file = "#{@hck_setup_scripts_path}/args.ps1.example" |
There was a problem hiding this comment.
No need to parse args.ps1.example. This is just an example and in this case we still duplicate knowlage about default password.
Currently, if you want to change password you have two places and args.ps1.example outside of this repo. Let's have one place for password, leave it only in config.json.
|
@menli820 General comments, please check |
Set a configurable HLK-client and HLK-server installation password, default to 'Assentor01'. Signed-off-by: menli <menli@redhat.com>
menli820
force-pushed
the
VIRTWINKVM-1829
branch
from
2551ad1 to
1865a8c
Compare
3 participants
Set a configurable HLK-client and HLK-server
installation password.
depend on: HCK-CI/HLK-Setup-Scripts#27
HCK-CI/AutoHCK-Installer#44