Add CODEOWNERS file to require PR approval from firmware lead
#110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchansen06
added
Documentation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces code formatting improvements to CMake files and adds a CODEOWNERS file for repository governance. The changes are primarily stylistic, reformatting function calls for consistency.
- Reformats CMake function calls across multiple platform-specific chip configuration files
- Adds a CODEOWNERS file to enforce code review requirements
- Standardizes multi-line formatting for
string(SUBSTRING...)calls in platform chip files
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Lib/cmake/gr-lib.cmake | Condenses cmake_language call to single line |
| Lib/Platform/STM32U5A9xJ/chip.cmake | Expands string(SUBSTRING...) to multi-line format |
| Lib/Platform/STM32L476xG/chip.cmake | Expands string(SUBSTRING...) to multi-line format |
| Lib/Platform/STM32G474xE/chip.cmake | Expands string(SUBSTRING...) to multi-line format |
| Lib/Platform/PlatformTemplate/chip.cmake | Expands string(SUBSTRING...) to multi-line format |
| .github/CODEOWNERS | Adds code ownership rules requiring firmware lead approval |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dchansen06
added a commit
that referenced
this pull request
Dec 4, 2025
# Code Owners ## Problem and Scope Current roles were overly restrictive (see #107) and blocked merges ## Description Require approval from the firmware lead in the `CODEOWNERS` file before merging ## Gotchas and Limitations Must keep the file up to date, anyone with root can override it of course ## Testing - [ ] HOOTL testing - [ ] HITL testing - [x] Human tested ### Testing Details To be seen, may auto-request reviews but that is life ## Larger Impact None as all PRs are already reviewed by firmware lead ## Additional Context and Ticket See the issues in #107 --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Owners
Problem and Scope
Current roles were overly restrictive (see #107) and blocked merges
Description
Require approval from the firmware lead in the
CODEOWNERSfile before mergingGotchas and Limitations
Must keep the file up to date, anyone with root can override it of course
Testing
Testing Details
To be seen, may auto-request reviews but that is life
Larger Impact
None as all PRs are already reviewed by firmware lead
Additional Context and Ticket
See the issues in #107