create Lib/Peripherals/ to house upcoming peripheral abstractions
#107
Conversation
dchansen06
added
Documentation
|
Also please update the PR title, thanks! |
GabeMillikan
changed the title
Lib/Inhouse directory for peripheral abstractionsLib/Peripherals/ to house upcoming peripheral abstractions
dchansen06
left a comment
dchansen06
left a comment
There was a problem hiding this comment.
To keep within scope of create
please remove the modifications to G4PERTESTING, these can be part of a separate PR as part of your implementation workLib/Peripherals/ to house upcoming peripheral abstractions
|
Fyi I am debugging why it says merging is blocked itia 
|
dchansen06
left a comment
dchansen06
left a comment
There was a problem hiding this comment.
Re-approving after ruleset update
Still no luck for me, but I'm not sure if I'm supposed to be able to merge into |
After PR approval you should be able to as well, but I am also blocked at the moment (though I can admin override that is not a fix) |
dchansen06
left a comment
dchansen06
left a comment
There was a problem hiding this comment.
Final approval after ruleset configuration
|
(I am turning off the rules to see if that fixes it and then turning them back on one-by-one, please do not merge) |
|
Should be good, can you please try merging it? |
# Code Owners ## Problem and Scope Current roles were overly restrictive (see #107) and blocked merges ## Description Require approval from the firmware lead in the `CODEOWNERS` file before merging ## Gotchas and Limitations Must keep the file up to date, anyone with root can override it of course ## Testing - [ ] HOOTL testing - [ ] HITL testing - [x] Human tested ### Testing Details To be seen, may auto-request reviews but that is life ## Larger Impact None as all PRs are already reviewed by firmware lead ## Additional Context and Ticket See the issues in #107 --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This reverts commit 1aba151.
dchansen06
force-pushed
the
gabe.peripherals-skeleton
branch
from
8a61a8a to
bfa8588
Compare
|
@GabeMillikan Please try squash merging when you are ready, thanks! |
@dchansen06 Worked! Thanks |
Awesome! @GabeMillikan Can you please try (updating the branch of) and confirming that #55 is not mergable at this point since it has not been approved? (If it is possible please do not actually merge though lol) |
@dchansen06 will do 🫡 |
looks like the new ruleset is working correctly 👍 |
|
Awesome thanks! That took way too long to fix lol (I was the one who broke it of course) |
# Code Owners ## Problem and Scope Current roles were overly restrictive (see #107) and blocked merges ## Description Require approval from the firmware lead in the `CODEOWNERS` file before merging ## Gotchas and Limitations Must keep the file up to date, anyone with root can override it of course ## Testing - [ ] HOOTL testing - [ ] HITL testing - [x] Human tested ### Testing Details To be seen, may auto-request reviews but that is life ## Larger Impact None as all PRs are already reviewed by firmware lead ## Additional Context and Ticket See the issues in #107 --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
2 participants
In the coming weeks, we'll be implementing abstractions for many different peripherals. We'll all be working in parallel in the same directory, so I'd like to set up that directory now so that we don't all have overlapping changes later.
I also added a "demo abstraction" for USART just to show how to setup CMake correctly, and what file structure we'd like to follow for each abstraction.