Skip to content

Add CODEOWNERS file to require PR approval from firmware lead #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dchansen06 merged 2 commits into from
Nov 10, 2025
Merged

Add CODEOWNERS file to require PR approval from firmware lead #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8114345
Add CODEOWNERS file to require approval from firmware lead
dchansen06 Nov 10, 2025
d97cc0f
Automatic CMake Format: Standardized formatting automatically
github-actions[bot] Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# All files require code owner approval from the firmware lead

## Previous firmware leads are not marked as Code Owners to not get notifications / called on for every PR, but they will have admin on GitHub and can merge PRs without approval

* @dchansen06
7 changes: 6 additions & 1 deletion Lib/Platform/PlatformTemplate/chip.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,12 @@ add_library(${CHIP}_LIB INTERFACE)
# enable_language(C ASM)

# used to strip the last 2 characters of CHIP to make the compile def
string(SUBSTRING ${CHIP} 0 9 TEMP) # FIXME Scary
string(
SUBSTRING ${CHIP}
0
9
TEMP
) # FIXME Scary
target_compile_definitions(
${CHIP}_LIB
INTERFACE
Expand Down
7 changes: 6 additions & 1 deletion Lib/Platform/STM32G474xE/chip.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,12 @@ endfunction()
add_library(${CHIP}_LIB INTERFACE)

# used to strip the last 2 characters of CHIP to make the compile def
string(SUBSTRING ${CHIP} 0 9 TEMP) # FIXME Scary
string(
SUBSTRING ${CHIP}
0
9
TEMP
) # FIXME Scary
target_compile_definitions(
${CHIP}_LIB
INTERFACE
Expand Down
7 changes: 6 additions & 1 deletion Lib/Platform/STM32L476xG/chip.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,12 @@ endfunction()
add_library(${CHIP}_LIB INTERFACE)

# used to strip the last 2 characters of CHIP to make the compile def
string(SUBSTRING ${CHIP} 0 9 TEMP) # FIXME Scary
string(
SUBSTRING ${CHIP}
0
9
TEMP
) # FIXME Scary
target_compile_definitions(
${CHIP}_LIB
INTERFACE
Expand Down
7 changes: 6 additions & 1 deletion Lib/Platform/STM32U5A9xJ/chip.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,12 @@ add_library(${CHIP}_LIB INTERFACE)

# enable_language(C ASM)

string(SUBSTRING ${CHIP} 0 9 TEMP) # FIXME Scary
string(
SUBSTRING ${CHIP}
0
9
TEMP
) # FIXME Scary
target_compile_definitions(
${CHIP}_LIB
INTERFACE
Expand Down
6 changes: 1 addition & 5 deletions Lib/cmake/gr-lib.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,7 @@ function(add_gr_project)
set(COMBINATOR "${GR_PROJECT}")
endif()

cmake_language(
CALL
add_executable_${Platform}
${TARGET_NAME}
)
cmake_language(CALL add_executable_${Platform} ${TARGET_NAME})

# Create unique interface library to avoid conflicts
set(INTERFACE_LIB "${COMBINATOR}_INTERFACE_LIB")
Expand Down