refactor: final tagging cleanup #19289
Open
+47
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 2, 2026
Contributor
Author
benesjan
commented
Jan 2, 2026
| // Having a large window significantly slowed down `e2e_l1_with_wall_time` test as there we perform sync for more than | ||
| // 1000 secrets. For this reason we set it to a relatively low value of 20. 20 should be sufficient for all the use | ||
| // cases. | ||
| export const UNFINALIZED_TAGGING_INDEXES_WINDOW_LEN = 20; |
Contributor
Author
There was a problem hiding this comment.
This is shared between sender and recipient sync algos so made sense to move it index.ts in the parent dir.
benesjan
changed the base branch from
12-23-feat_expanding_return_value_of_getlogsbytags
to
graphite-base/19289
benesjan
force-pushed
the
graphite-base/19289
branch
from
f3df451 to
c81bf33
Compare
benesjan
force-pushed
the
01-02-refactor_final_tagging_cleanup
branch
from
ba9816c to
d47f725
Compare
benesjan
changed the base branch from
graphite-base/19289
to
12-23-feat_expanding_return_value_of_getlogsbytags
benesjan
force-pushed
the
01-02-refactor_final_tagging_cleanup
branch
from
d47f725 to
0be558e
Compare
AztecBot
force-pushed
the
12-23-feat_expanding_return_value_of_getlogsbytags
branch
2 times, most recently
from
6d58c3d to
ceabd1c
Compare
Base automatically changed from
12-23-feat_expanding_return_value_of_getlogsbytags
to
next
January 2, 2026 19:18
benesjan
force-pushed
the
01-02-refactor_final_tagging_cleanup
branch
from
0be558e to
8e0f190
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I move tagging related functionality around in order for it to be in a resonable place. Not done before to have the previous PRs be reviewable.
The sender sync algo was implemented first and for this reason it was in
tagging/syncdir. In this PR I moved it totagging/sender_syncand move a bunch of other stuff around.