refactor!: expanding return value of getLogsByTags #19233
Merged
+248
−479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2025
Contributor
Author
benesjan
force-pushed
the
12-18-feat_integrating_new_log_sync
branch
from
47bce0f to
6e01080
Compare
benesjan
force-pushed
the
12-23-feat_expanding_return_value_of_getlogsbytags
branch
from
371a484 to
1ecae46
Compare
benesjan
changed the base branch from
12-18-feat_integrating_new_log_sync
to
graphite-base/19233
benesjan
force-pushed
the
12-23-feat_expanding_return_value_of_getlogsbytags
branch
from
1ecae46 to
ec04be9
Compare
benesjan
changed the base branch from
graphite-base/19233
to
12-18-feat_integrating_new_log_sync
benesjan
added
the
ci-no-fail-fast
benesjan
force-pushed
the
12-18-feat_integrating_new_log_sync
branch
from
6a3088c to
7912feb
Compare
benesjan
force-pushed
the
12-23-feat_expanding_return_value_of_getlogsbytags
branch
from
ec04be9 to
6b89008
Compare
benesjan
changed the title
benesjan
commented
Dec 24, 2025
benesjan
commented
Dec 24, 2025
benesjan
commented
Dec 24, 2025
benesjan
commented
Dec 24, 2025
benesjan
commented
Dec 24, 2025
benesjan
commented
Dec 24, 2025
benesjan
force-pushed
the
12-23-feat_expanding_return_value_of_getlogsbytags
branch
from
eb9692a to
f8d4387
Compare
mverzilli
approved these changes
Jan 2, 2026
AztecBot
force-pushed
the
12-18-feat_integrating_new_log_sync
branch
2 times, most recently
from
b0b6b93 to
2e43de7
Compare
benesjan
force-pushed
the
12-23-feat_expanding_return_value_of_getlogsbytags
branch
from
1872a26 to
460b312
Compare
benesjan
force-pushed
the
12-18-feat_integrating_new_log_sync
branch
from
2e43de7 to
035f44f
Compare
benesjan
force-pushed
the
12-23-feat_expanding_return_value_of_getlogsbytags
branch
from
460b312 to
f3df451
Compare
AztecBot
force-pushed
the
12-18-feat_integrating_new_log_sync
branch
2 times, most recently
from
64e4233 to
445ca57
Compare
benesjan
force-pushed
the
12-23-feat_expanding_return_value_of_getlogsbytags
branch
from
f3df451 to
1ff6722
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
benesjan
force-pushed
the
12-23-feat_expanding_return_value_of_getlogsbytags
branch
from
1ff6722 to
c81bf33
Compare
benesjan
added
ci-squash-and-merge
and removed
ci-no-fail-fast
benesjan
commented
Jan 2, 2026
| // docs:end:l1-withdraw | ||
| expect(newL1Balance).toBe(withdrawAmount); | ||
| }, 90000); | ||
| }, 110_000); |
Contributor
Author
There was a problem hiding this comment.
This timed out in merge queue. I think this PR did not affect but the one down the stack did. As discussed on slack the new log sync algo is a bit slower because we have WINDOW_LEN of 20 and not 10 like before.
AztecBot
force-pushed
the
12-23-feat_expanding_return_value_of_getlogsbytags
branch
from
19565d5 to
6d58c3d
Compare
Fixes F-231 Fixes #9789 In this PR I modify the the return value of our "get logs by tags" endpoints such that we don't need to perform another request for tx hash in PXE's log service. Since I was already modifying it I also dropped unused values from the type and made it a bit less messy. I added here migration notes for all the changes I did to the endpoint not only in this PR but also in PRs down the stack.
AztecBot
force-pushed
the
12-23-feat_expanding_return_value_of_getlogsbytags
branch
from
6d58c3d to
ceabd1c
Compare
AztecBot
deleted the
12-23-feat_expanding_return_value_of_getlogsbytags
branch
github-actions bot
pushed a commit
that referenced
this pull request
Jan 2, 2026
Fixes F-231 Fixes #9789 In this PR I modify the the return value of our "get logs by tags" endpoints such that we don't need to perform another request for tx hash in PXE's log service. Since I was already modifying it I also dropped unused values from the type and made it a bit less messy. I added here migration notes for all the changes I did to the endpoint not only in this PR but also in PRs down the stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes F-231
Fixes #9789
In this PR I modify the the return value of our "get logs by tags" endpoints such that we don't need to perform another request for tx hash in PXE's log service. Since I was already modifying it I also dropped unused values from the type and made it a bit less messy.
I added here migration notes for all the changes I did to the endpoint not only in this PR but also in PRs down the stack.