feat: integrating new log sync #19125
Merged
+302
−791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 18, 2025
Contributor
Author
benesjan
force-pushed
the
12-15-refactor_more_robust_tagging_index_sync_as_recipient
branch
from
d8fc670 to
ce35192
Compare
benesjan
force-pushed
the
12-18-feat_integrating_new_log_sync
branch
from
9dfb49e to
96a2caa
Compare
benesjan
added
ci-squash-and-merge
ci-no-fail-fast
benesjan
force-pushed
the
12-15-refactor_more_robust_tagging_index_sync_as_recipient
branch
from
ce35192 to
440c4f6
Compare
benesjan
force-pushed
the
12-18-feat_integrating_new_log_sync
branch
from
03ff16f to
4248f60
Compare
benesjan
force-pushed
the
12-15-refactor_more_robust_tagging_index_sync_as_recipient
branch
from
440c4f6 to
dba8831
Compare
benesjan
force-pushed
the
12-18-feat_integrating_new_log_sync
branch
from
4248f60 to
68eecc3
Compare
benesjan
force-pushed
the
12-15-refactor_more_robust_tagging_index_sync_as_recipient
branch
from
dba8831 to
bbe743a
Compare
benesjan
force-pushed
the
12-18-feat_integrating_new_log_sync
branch
3 times, most recently
from
1d52d40 to
2644665
Compare
benesjan
force-pushed
the
12-18-feat_integrating_new_log_sync
branch
from
2644665 to
7df5f00
Compare
benesjan
force-pushed
the
12-15-refactor_more_robust_tagging_index_sync_as_recipient
branch
from
370568a to
1b335df
Compare
benesjan
changed the base branch from
12-15-refactor_more_robust_tagging_index_sync_as_recipient
to
graphite-base/19125
benesjan
force-pushed
the
12-18-feat_integrating_new_log_sync
branch
from
7df5f00 to
d45dade
Compare
benesjan
force-pushed
the
graphite-base/19125
branch
from
1b335df to
fb60766
Compare
benesjan
changed the base branch from
graphite-base/19125
to
12-19-feat_optimizing_aztecnode_getlogsbytags_for_new_log_sync_algo
benesjan
commented
Dec 31, 2025
yarn-project/pxe/src/storage/tagging_data_provider/sender_address_book.ts
Show resolved
Hide resolved
benesjan
commented
Dec 31, 2025
yarn-project/pxe/src/tagging/recipient_sync/recipient_tagging_data_provider.ts
Show resolved
Hide resolved
benesjan
commented
Dec 31, 2025
noir-projects/noir-contracts/contracts/test/pending_note_hashes_contract/src/main.nr
Show resolved
Hide resolved
mverzilli
approved these changes
Jan 2, 2026
Contributor
mverzilli
left a comment
mverzilli
left a comment
There was a problem hiding this comment.
Nice job! Only some nits to discuss but they don't need to block the PR
yarn-project/pxe/src/storage/tagging_data_provider/sender_address_book.ts
Show resolved
Hide resolved
benesjan
added
ci-squash-and-merge
and removed
ci-no-fail-fast
AztecBot
force-pushed
the
12-18-feat_integrating_new_log_sync
branch
from
170490c to
b0b6b93
Compare
AztecBot
force-pushed
the
12-18-feat_integrating_new_log_sync
branch
from
b0b6b93 to
2e43de7
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
benesjan
force-pushed
the
12-18-feat_integrating_new_log_sync
branch
from
2e43de7 to
035f44f
Compare
AztecBot
force-pushed
the
12-18-feat_integrating_new_log_sync
branch
from
469c4cb to
64e4233
Compare
Fixes #17775 In this PR I integrate the new recipient log sync algo and the old one gets dropped. The file structure is still a bit messy but that I will handle in a followup PR to make this PR not insane to review. I Introduced `SenderAddressBook` that was originally part of `RecipientTaggingDataProvider`. I decided to do this separation because I want the new log sync algo to not be aware of sender addresses etc. - I wanted it to deal only with `DirectionalAppTaggingSecret`s as it feels like a nice separation.
AztecBot
force-pushed
the
12-18-feat_integrating_new_log_sync
branch
from
64e4233 to
445ca57
Compare
This was referenced Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17775
In this PR I integrate the new recipient log sync algo and the old one gets dropped. The file structure is still a bit messy but that I will handle in a followup PR to make this PR not insane to review.
I Introduced
SenderAddressBookthat was originally part ofRecipientTaggingDataProvider. I decided to do this separation because I want the new log sync algo to not be aware of sender addresses etc. - I wanted it to deal only withDirectionalAppTaggingSecrets as it feels like a nice separation.