Skip to content

test: Potential fix for 1 code quality finding in tests/zip_crypto.rs #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pr0methean merged 1 commit into from
Feb 2, 2026
Merged

test: Potential fix for 1 code quality finding in tests/zip_crypto.rs #607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/zip_crypto.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,10 +136,10 @@ fn test_partial_buffer_read_crypto() {
// choose the minimum value here (13 bytes) to use the smallest capacity that still triggers
// the intended partial-buffer read behavior for this ZIP fixture; smaller values would not
// exercise that code path, and larger values might cause the entire block to be read at once.
const MIN_PARTIAL_READ_BUFFER_SIZE: usize = 13;
const PARTIAL_READ_TRIGGER_BUFFER_SIZE: usize = 13;

let zip_file_bytes = &mut Cursor::new(ZIP_CRYPTO_FILE);
let buffered = BufReader::with_capacity(MIN_PARTIAL_READ_BUFFER_SIZE, zip_file_bytes);
let buffered = BufReader::with_capacity(PARTIAL_READ_TRIGGER_BUFFER_SIZE, zip_file_bytes);
let mut archive = zip::ZipArchive::new(buffered).unwrap();

let mut file = archive.by_index_decrypt(0, b"test").unwrap();
Expand Down