improve zig exe lookup when using symlinks, scripts or version managers #2590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The zig executable may be some kind of proxy that internally forwards to different Zig versions. When ZLS runs the zig executable in different locations (e.g. packages in the global zig cache), this may cause multiple Zig versions to be downloaded and used which can cause all kinds of issues. This change will ensure that the proxy will only ever be queried once by using the `zig_exe` field from the `zig env` output. If `zig env` fails, the zig exe path will be unset and any zig compiler integrated will be disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zig executable may be some kind of proxy that internally forwards to different Zig versions. When ZLS runs the zig executable in different locations (e.g. packages in the global zig cache), this may cause multiple Zig versions to be downloaded and used which can cause all kinds of issues.
This change will ensure that the proxy will only ever be queried once by using the
zig_exefield from thezig envoutput. Ifzig envfails, the zig exe path will be unset and any zig compiler integrated will be disabled.